feat: add compile-time size check for events and error code links#21024
Merged
nventuro merged 6 commits intomerge-train/fairiesfrom Mar 3, 2026
Merged
feat: add compile-time size check for events and error code links#21024nventuro merged 6 commits intomerge-train/fairiesfrom
nventuro merged 6 commits intomerge-train/fairiesfrom
Conversation
Add a static_assert to the #[event] macro that validates event serialized
length does not exceed MAX_EVENT_SERIALIZED_LEN, mirroring the existing
check in the #[note] macro. Add error code URLs to both the note and
event static_assert messages linking to docs.aztec.network/errors/{4,5},
with corresponding netlify redirects. Add an invalid_event compile
failure test.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
@nventuro The code in this PR was broken so I fixed it. The fixes I needed to do are in the last 3 commits. |
Collaborator
|
❌ Failed to cherry-pick to |
AztecBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
…1024) This adds the static assert for packing length that we had in #[note] to future we may have information as to how to proceed (e.g. what to do with too-long events etc). --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: benesjan <janbenes1234@gmail.com>
This was referenced Mar 3, 2026
Closed
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
BEGIN_COMMIT_OVERRIDE feat: allow custom addresses to be prefunded with fee juice in local network (#21000) docs(claude): add Noir early return idiom to CLAUDE.md (#21021) feat: add compile-time size check for events and error code links (#21024) feat: use warn_log_format for discarded messages (#21053) END_COMMIT_OVERRIDE
johnathan79717
pushed a commit
that referenced
this pull request
Mar 4, 2026
…1024) This adds the static assert for packing length that we had in #[note] to #[event] as well, and also adds links to the docsite, where in the future we may have information as to how to proceed (e.g. what to do with too-long events etc). --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: benesjan <janbenes1234@gmail.com>
AztecBot
added a commit
that referenced
this pull request
Mar 18, 2026
nventuro
added a commit
that referenced
this pull request
Mar 19, 2026
…1134, #21072, #21186, #21189, #21229, #21228, #21234, #21639) (#21745) ## Summary Combined backport of 12 PRs to v4-next, cherry-picked in chronological merge order: 1. #20512 — docs: add delayedpublicmutable apiref, fix misc docs 2. #20379 — feat: custom message handlers in Aztec.nr 3. #20831 — feat!: make unused msg disco fns private 4. #21024 — feat: add compile-time size check for events and error code links 5. #21134 — chore: add warning on invalid recipients 6. #21072 — feat: add aztecaddress::is_valid 7. #21186 — chore: use returns `true` for boolean fns 8. #21189 — feat: add note hash and nullifier helper functions with domain separation 9. #21229 — docs: small delayedpubmut update 10. #21228 — test: restore pubmut tests 11. #21234 — fix: claim contract & improve nullif docs 12. #21639 — feat!: split compute note hash and nullifier to reduce hashing Each PR is a separate commit (raw cherry-pick with conflicts left in), followed by a single final commit that resolves all conflicts — making it easy to review the conflict resolution independently. ## Conflict resolution (last commit) - `delayed_public_mutable.nr` / `public_immutable.nr` — merged doc comments from both sides - `aztec.nr` macros — integrated custom message handler + split compute functions - `discovery/mod.nr` / `process_message.nr` — merged offchain inbox sync + custom handler dispatch + split compute - `constants.nr` / `constants_tests.nr` — added new domain separators - `Nargo.toml` — added custom_message_contract - `netlify.toml` — merged error code redirects - `auth_contract` — kept v4-next delay value - `note_metadata.nr` — doc comment reformat - `migration_notes.md` — merged migration notes from both sides - Deleted `traits.nr` (v4-next uses `traits/` directory) ClaudeBox log: https://claudebox.work/s/3145d1bd30977c20?run=1 --------- Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the static assert for packing length that we had in #[note] to #[event] as well, and also adds links to the docsite, where in the future we may have information as to how to proceed (e.g. what to do with too-long events etc).