chore: backport #21024 (compile-time size check for events and error code links) to v4#21056
Closed
chore: backport #21024 (compile-time size check for events and error code links) to v4#21056
Conversation
…1024) This adds the static assert for packing length that we had in #[note] to future we may have information as to how to proceed (e.g. what to do with too-long events etc). --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: benesjan <janbenes1234@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #21024 to v4.
Changes
static_assertin the#[event]macroinvalid_eventcompile failure testConflict Resolution
The only conflict was in
docs/netlify.toml— v4 had only the example comment template for error codes, while next already had error codes 1-3. Resolved by taking the incoming side with all error codes 1-5.ClaudeBox log: http://ci.aztec-labs.com/fc248802fe819834-1