Closed
Conversation
85a5879 to
b574da7
Compare
Collaborator
|
API change check API changes are not detected in this pull request. |
b574da7 to
1673372
Compare
Member
Author
|
Leave direct dependency |
Member
Author
|
Closing to stash warnings instead. |
Member
Author
|
Looks like because we pass entry_point.dist to get_dist_dependency_conflicts, this would then cause an issue. The dist works differently for importlib_metadata: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove deprecated pkg_resources. Replace with importlib_metadata. Related PRs:
open-telemetry/opentelemetry-python#3167
open-telemetry/opentelemetry-python-contrib#1973
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines