Using importlib_metadata for entry points instead of pkg_resources#1973
Closed
jeremydvoss wants to merge 3 commits intoopen-telemetry:mainfrom
Closed
Using importlib_metadata for entry points instead of pkg_resources#1973jeremydvoss wants to merge 3 commits intoopen-telemetry:mainfrom
jeremydvoss wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
jeremydvoss
force-pushed
the
no-iter-entry-points
branch
from
ae5e470 to
4353f26
Compare
6 tasks
jeremydvoss
force-pushed
the
no-iter-entry-points
branch
from
2b48df6 to
bdc0c4a
Compare
|
Any chance to see this PR moving forward please? Can I help in some ways? |
|
@jeremydvoss can I help you finalize this PR? |
|
@jeremydvoss Do you have any plan with this change? It would be great if these warnings get fixed! 🙇 |
Contributor
|
@jeremydvoss, do need any help with this PR? |
|
It has been several months already without any updates or comments. I will try to propose a new change on top of this one in the coming days, with updated code to fix all the warnings. |
|
Actually, it's already picked up in #2181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pkg_resources is deprecated. Following example of https://github.com/open-telemetry/opentelemetry-python/pull/3217/files
Helps to fix #1970
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Existing tests
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.