Skip to content

wait for app property queries by list to return results in UI app registration creation#155

Merged
glennmusa merged 8 commits intomainfrom
glennmusa/apppropertyquery
Apr 15, 2021
Merged

wait for app property queries by list to return results in UI app registration creation#155
glennmusa merged 8 commits intomainfrom
glennmusa/apppropertyquery

Conversation

@glennmusa
Copy link
Copy Markdown
Contributor

@glennmusa glennmusa commented Apr 15, 2021

Description

There's transient issues when setup_ezdeploy.sh attempts to source the App Registration password to store in KeyVault in AzureUsGovernment. This change adds a "wait for an app registration property query to return a result" function that hopes to prevent the query for app registration by ID from az ad app credential reset on L110 from failing.

The underlying AZ CLI implementation queries for service principal by name:

https://github.com/Azure/azure-cli/blob/a4582a388033dde268fad640656acfe1a5781a64/src/azure-cli/azure/cli/command_modules/role/custom.py#L1703

Issue reference

The issue this PR will close: #144

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa glennmusa changed the title add wait for app property query to UI app registration creation wait for app property queries to return results in UI app registration creation Apr 15, 2021
@glennmusa glennmusa merged commit d93b9c9 into main Apr 15, 2021
@glennmusa glennmusa deleted the glennmusa/apppropertyquery branch April 15, 2021 17:17
@glennmusa glennmusa changed the title wait for app property queries to return results in UI app registration creation wait for app property queries by list to return results in UI app registration creation Apr 15, 2021
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup_ezdeploy fails when trying to deploy into Azure Government

2 participants