Skip to content

wait for app property queries by list to return results in UI app registration creation #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glennmusa merged 8 commits into from
Apr 15, 2021
Merged

wait for app property queries by list to return results in UI app registration creation #155

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6234acd
source UI cloud settings from configuration
glennmusa Apr 13, 2021
f7599c8
pass cloud name to UI defaults
glennmusa Apr 14, 2021
4e71fc5
execute terraform from other clouds
glennmusa Apr 14, 2021
45aa296
remove argument that comes from azure cloud show
glennmusa Apr 14, 2021
40ed50a
update comment for clarity
glennmusa Apr 14, 2021
3fcb7d6
add wait for app query
glennmusa Apr 15, 2021
2ad718b
Merge branch 'main' into glennmusa/apppropertyquery
glennmusa Apr 15, 2021
7b97671
query from a list instead
glennmusa Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions src/scripts/container-registry/add_auth_scopes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,40 @@ wait_for_app_creation() {
done
}

# accomodate for transient behavior where App Registration is created
# but an immediate query for its properties will fail
# and attempt for max_wait_in_seconds before giving up.
wait_for_app_query_from_list() {
app_name_to_query=$1
property_to_query=$2

property_query="az ad app list --display-name ${app_name_to_query} --query [].${property_to_query} --output tsv"

sleep_time_in_seconds=10
max_wait_in_seconds=180
max_retries=$((max_wait_in_seconds/sleep_time_in_seconds))

count=1

while [[ -z $($property_query) ]]
do
echo "INFO: waiting for query \"${property_query}\" to return results (${count}/${max_retries})"
echo "INFO: trying again in ${sleep_time_in_seconds} seconds..."
sleep "${sleep_time_in_seconds}"

if [[ ${count} -eq max_retries ]]; then
error_log "ERROR: unable to get results from query \"${property_query}\" in ${max_wait_in_seconds} seconds. Investigate and re-run script."
exit 1
fi

count=$((count +1))
done
}

wait_for_app_creation "${app_id}"
wait_for_app_query_from_list "${mlz_fe_app_name}" "appId"

echo "INFO: sourcing app registration information for app ID ${app_id}..."
client_password=$(az ad app credential reset \
--id ${app_id} \
--query password \
Expand Down