Fix wrong issue for valid min/max in class property#356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #355 :
A validation issue was erroneously added to the report when a non-scalar class property defined (valid)
min/maxproperties.The reason was simply a missing
return. It continued the validation there, assuming that the property was an array, even though it wasn't.There currently are validation/spec files like the
FullMetadataSchema.jsonand thevalidSchema.jsonfor the baseline checks of valid schemas. But these do not explore the full range of possible valid schemas. I.e. they don't contain all (valid) combinations of things likemin/max/offset/scale/required/noData/...etc. A new file,validSchemaWithMinMax.json, is added here, as a regression test. Approaches for more systematically generating 'all' valid schemas might be considered.