Binary property value validation in glTF#357
Merged
Conversation
Contributor
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #353
Builds upon #356
This adds the validation of the values of property tables in glTF. Until now, only the structure (i.e. the JSON schema structure, and the sizes of buffer views) had been validated. This PR mainly adds a call to the binary property table value validation. This already existed (for subtree validation), but is now also applied to the binary property tables that are stored in glTF.
Only the first commit is relevant.
The second commit only fixes typos in comments and variable names. (I have installed that spell checker for VSCode in the meantime, and these blue markers have been bugging me...).