fix: do not show share thread button if allow_threadsharing is set to false#2708
Merged
hayescode merged 2 commits intoChainlit:mainfrom Dec 4, 2025
Merged
Conversation
eiseleMichael
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
dosubot
bot
added
size:S
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
hayescode
approved these changes
Dec 4, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
… false (#2708) closes #2645 ps: formatting is from lint staged <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Hide the “Share Thread” button in the sidebar when thread sharing is disabled or not ready, so users don’t see a non-working action. Only render the share action when both dataPersistence and threadSharingReady are true. <sup>Written for commit 01445bd. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> Co-authored-by: Josh Hayes <35790761+hayescode@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2645
ps: formatting is from lint staged
Summary by cubic
Hide the “Share Thread” button in the sidebar when thread sharing is disabled or not ready, so users don’t see a non-working action. Only render the share action when both dataPersistence and threadSharingReady are true.
Written for commit 01445bd. Summary will update automatically on new commits.