Skip to content

PNE-816 take2#980

Merged
pacdaemon merged 3 commits intomainfrom
routing-take2
Nov 18, 2024
Merged

PNE-816 take2#980
pacdaemon merged 3 commits intomainfrom
routing-take2

Conversation

@robbtraister
Copy link
Copy Markdown
Contributor

@robbtraister robbtraister commented Nov 15, 2024 •
edited by atlassian Bot
Loading

Citrine Python PR

PNE-816

Description

This PR restores #978 and #976 returning us to #977.

The additional change necessary to get things working is to specify the correct version in the projects search API.

I also manually ran devkit against the previous attempt (from #977) and this branch to see that the former fails and the latter succeeds.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@pacdaemon pacdaemon marked this pull request as ready for review November 18, 2024 15:31
@pacdaemon pacdaemon requested a review from a team as a code owner November 18, 2024 15:31
@pacdaemon pacdaemon merged commit 455e12e into main Nov 18, 2024
@pacdaemon pacdaemon deleted the routing-take2 branch November 18, 2024 15:32
@pacdaemon pacdaemon mentioned this pull request Nov 18, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pacdaemon pacdaemon pacdaemon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robbtraister @pacdaemon