Skip to content

feat: remember last selected camera for barcode scanning#822

Merged
CodeWithCJ merged 1 commit intoCodeWithCJ:mainfrom
Sim-sat:save-camera-id
Mar 2, 2026
Merged

feat: remember last selected camera for barcode scanning#822
CodeWithCJ merged 1 commit intoCodeWithCJ:mainfrom
Sim-sat:save-camera-id

Conversation

@Sim-sat
Copy link
Contributor

@Sim-sat Sim-sat commented Mar 2, 2026

Description

Saves the selected camera in localstorage just like the scanner engine. This improves usage on smartphones with multiple cameras.

Related Issue

PR type [ ] Issue [ ] New Feature [x] Documentation
Linked Issue: #786

Checklist

Please check all that apply:

  • [MANDATORY for new feature] Alignment: I have raised a GitHub issue and it was reviewed/approved by maintainers
  • Tests: I have included automated tests for my changes.
  • [MANDATORY for UI changes] Screenshots: I have attached "Before" vs "After" screenshots below.
  • [MANDATORY for Frontend changes] Quality: I have run pnpm run validate (especially for Frontend).
  • Translations: I have only updated the English (en) translation file (if applicable).
  • Architecture: My code follows the existing architecture standards.
  • Database Security: I have updated rls_policies.sql for any new user-specific tables.
  • [MANDATORY - ALL] Integrity & License: I certify this is my own work, free of malicious code(phishing, malware, etc.) and I agree to the License terms.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the barcode scanning feature by implementing persistence for the user's camera selection. By saving the last chosen camera ID to local storage, the application improves usability, especially for users with multiple cameras on their smartphones, as it eliminates the need to re-select the preferred camera on subsequent uses.

Highlights

  • Camera selection persistence: The selectedCameraId state is now initialized by attempting to retrieve the last selected camera ID from localStorage, ensuring that the user's preference is remembered across sessions.
  • Camera change handler: A new handleCameraChange function was introduced to manage camera selection. This function updates the component's state and persists the chosen camera ID to localStorage for future use, including error handling for localStorage operations.
  • UI integration: The camera selection dropdown (Select component) was updated to utilize the new handleCameraChange function, ensuring that user selections are properly saved and reflected.
Changelog
  • SparkyFitnessFrontend/src/components/FoodSearch/BarcodeScanner.tsx
    • Initialized selectedCameraId state from localStorage to remember the last selected camera.
    • Added handleCameraChange function to update the selected camera ID and save it to localStorage.
    • Updated the camera Select component to use the new handleCameraChange function for persisting selections.
Activity
  • No activity (comments, reviews, etc.) was provided in the context for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds functionality to remember the last selected camera for barcode scanning by saving it to localStorage. The implementation correctly follows the existing pattern for persisting other settings like the scanner engine. However, this has introduced more code duplication for handling localStorage. My review includes a suggestion to refactor this logic into a reusable useLocalStorage custom hook to improve code maintainability and consistency.

@CodeWithCJ CodeWithCJ merged commit 3224f94 into CodeWithCJ:main Mar 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants