Skip to content

feat: remember last selected camera for barcode scanning #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeWithCJ merged 1 commit into from
Mar 2, 2026
Merged

feat: remember last selected camera for barcode scanning #822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions SparkyFitnessFrontend/src/components/FoodSearch/BarcodeScanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,14 @@ const BarcodeScanner: React.FC<BarcodeScannerProps> = ({
}, [selectedEngine]);
// Camera Selection
const [cameras, setCameras] = useState<MediaDeviceInfo[]>([]);
const [selectedCameraId, setSelectedCameraId] = useState<string>('');
const [selectedCameraId, setSelectedCameraId] = useState<string>(() => {
try {
const stored = localStorage.getItem('barcodeCameraId');
return stored || '';
} catch {
return '';
}
});

// Scanning State
const [scanLine, setScanLine] = useState(false);
Expand Down Expand Up @@ -294,6 +301,15 @@ const BarcodeScanner: React.FC<BarcodeScannerProps> = ({
[]
);

const handleCameraChange = (id: string) => {
setSelectedCameraId(id);
try {
localStorage.setItem('barcodeCameraId', id);
} catch (e) {
console.error('Failed to save camera selection to localStorage', e);
}
};

const handleEngineChange = (newEngine: string) => {
setSelectedEngine(newEngine);
try {
Expand Down Expand Up @@ -323,10 +339,7 @@ const BarcodeScanner: React.FC<BarcodeScannerProps> = ({
</Select>

{cameras.length > 0 && (
<Select
value={selectedCameraId}
onValueChange={setSelectedCameraId}
>
<Select value={selectedCameraId} onValueChange={handleCameraChange}>
<SelectTrigger className="w-full max-w-[150px] bg-black/60 text-white border-gray-600 h-8 text-xs">
<Camera className="w-3 h-3 mr-2" />
<SelectValue placeholder="Camera" />
Expand Down