bundle identifier change for android app

[CodeWithCJ]

Tip

Help us review and merge your PR faster!
Please ensure you have completed the Checklist below.
For Frontend changes, please run pnpm run validate to check for any errors.
PRs that include tests and clear screenshots are highly preferred!

Description

Provide a brief summary of your changes.

Related Issue

PR type [ ] Issue [ ] New Feature [ ] Documentation
Linked Issue: #

Checklist

Please check all that apply:

• [MANDATORY for new feature] Alignment: I have raised a GitHub issue and it was reviewed/approved by maintainers
• Tests: I have included automated tests for my changes.
• [MANDATORY for UI changes] Screenshots: I have attached "Before" vs "After" screenshots below.
• [MANDATORY for Frontend changes] Quality: I have run pnpm run validate (especially for Frontend).
• Translations: I have only updated the English (en) translation file (if applicable).
• Architecture: My code follows the existing architecture standards.
• Database Security: I have updated rls_policies.sql for any new user-specific tables.
• [MANDATORY - ALL] Integrity & License: I certify this is my own work, free of malicious code(phishing, malware, etc.) and I agree to the License terms.

Screenshots (if applicable)

Before

[Insert screenshot/GIF here]

After

[Insert screenshot/GIF here]

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the application's build configuration and identity for Android. The core change involves updating the Android production bundle identifier to align with standard naming conventions. Additionally, the EAS build process has been enhanced to support distinct app variants across development, preview, and production environments, which improves the flexibility and management of different application builds. These changes are supported by necessary dependency updates to ensure compatibility and leverage the latest Expo tooling.

Highlights

• Android Bundle Identifier Update: The Android production bundle identifier has been updated from 'org.SparkyApps.SparkyFitnessMobile' to 'com.SparkyApps.SparkyFitnessMobile' in app.config.ts.
• EAS Build Configuration Enhancements: Environment variables (APP_VARIANT) have been introduced in eas.json for development, preview, and production build profiles to better manage app variants.
• Dependency Updates: The @expo/config-plugins dependency has been added to devDependencies and its version, along with related Expo packages, has been updated in the pnpm-lock.yaml.

Changelog

• SparkyFitnessMobile/app.config.ts
  • Changed the ANDROID_PROD_BUNDLE_IDENTIFIER from org.SparkyApps.SparkyFitnessMobile to com.SparkyApps.SparkyFitnessMobile.
• SparkyFitnessMobile/eas.json
  • Introduced env.APP_VARIANT for development, preview, and production build configurations.
  • Set APP_VARIANT to development for the development build.
  • Set APP_VARIANT to preview for the preview build.
  • Set APP_VARIANT to production for the production build.
• SparkyFitnessMobile/package.json
  • Added @expo/config-plugins with version ^55.0.6 to devDependencies.
• pnpm-lock.yaml
  • Updated the version of @expo/config-plugins for react-native-health-connect.
  • Added new entries for @expo/config-plugins@55.0.6, @expo/config-types@55.0.5, and @expo/plist@0.5.2.
  • Updated the dependency resolution for @expo/config-plugins and @expo/plist.

Activity

• No human activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the Android bundle identifier to align with the iOS one, using a com. TLD. It also introduces environment variables for different EAS build profiles (development, preview, production). The changes are generally good, but I've identified a potential issue with the preview build configuration that could cause installation conflicts with the production app. I've also suggested a minor improvement for consistency in the development bundle identifier.

_{Note: Security Review did not run due to the size of the PR.}

[gemini-code-assist]

By setting APP_VARIANT to preview, the app config will use production bundle identifiers for preview builds. This might not be what you want, as it prevents installing preview and production builds on the same device. Consider creating a separate bundle identifier for preview builds and updating the logic in app.config.ts to use it when process.env.APP_VARIANT === 'preview'.

[gemini-code-assist]

This change makes the Android production bundle identifier consistent with the iOS one, which is great. For full consistency, you might also want to update DEV_BUNDLE_IDENTIFIER on line 8 to use the com. TLD, e.g., com.SparkyApps.SparkyFitnessMobile.dev.