Skip to content

bundle identifier change for android app #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeWithCJ merged 1 commit into from
Mar 7, 2026
Merged

bundle identifier change for android app #867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SparkyFitnessMobile/app.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { ExpoConfig, ConfigContext } from 'expo/config';

const APP_NAME = 'SparkyFitness';
const APP_SLUG = 'sparkyfitnessmobile';
const ANDROID_PROD_BUNDLE_IDENTIFIER = 'org.SparkyApps.SparkyFitnessMobile';
const ANDROID_PROD_BUNDLE_IDENTIFIER = 'com.SparkyApps.SparkyFitnessMobile';
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change makes the Android production bundle identifier consistent with the iOS one, which is great. For full consistency, you might also want to update DEV_BUNDLE_IDENTIFIER on line 8 to use the com. TLD, e.g., com.SparkyApps.SparkyFitnessMobile.dev.

const IOS_PROD_BUNDLE_IDENTIFIER = 'com.SparkyApps.SparkyFitnessMobile';
const DEV_BUNDLE_IDENTIFIER = 'org.SparkyApps.SparkyFitnessMobile.dev';

Expand Down
9 changes: 9 additions & 0 deletions SparkyFitnessMobile/eas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,22 @@
},
"build": {
"development": {
"env": {
"APP_VARIANT": "development"
},
"developmentClient": true,
"distribution": "internal"
},
"preview": {
"env": {
"APP_VARIANT": "preview"
},
"distribution": "internal"
},
Comment on lines 14 to 19
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

By setting APP_VARIANT to preview, the app config will use production bundle identifiers for preview builds. This might not be what you want, as it prevents installing preview and production builds on the same device. Consider creating a separate bundle identifier for preview builds and updating the logic in app.config.ts to use it when process.env.APP_VARIANT === 'preview'.

"production": {
"env": {
"APP_VARIANT": "production"
},
"autoIncrement": true,
"android": {
"buildType": "app-bundle"
Expand Down
1 change: 1 addition & 0 deletions SparkyFitnessMobile/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
"devDependencies": {
"@babel/core": "^7.25.2",
"@babel/runtime": "^7.25.0",
"@expo/config-plugins": "^55.0.6",
"@testing-library/react-native": "^13.3.3",
"@types/jest": "29.5.14",
"@types/react": "~19.1.10",
Expand Down
44 changes: 41 additions & 3 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading