Remove DisableAutoCancel to fix Android auto focus#2169
Merged
TheCodeTraveler merged 2 commits intoSep 3, 2024
Merged
Conversation
Contributor
Author
|
@dotnet-policy-service agree |
bijington
approved these changes
Sep 3, 2024
Contributor
bijington
left a comment
bijington
left a comment
There was a problem hiding this comment.
Thanks @Jake-Derrick I appreciate this!
Contributor
|
Looks like we still have flaky tests :( |
|
Thank you @Jake-Derrick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Remove the use of DisableAutoCancel to allow CameraX to automatically cancel focus and metering actions after the default duration, enabling continuous auto-focus behavior rather than being locked into the initial focal point.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
See #2103 (comment) for video example