Skip to content

Remove DisableAutoCancel to fix Android auto focus #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheCodeTraveler merged 2 commits into from
Sep 3, 2024
Merged

Remove DisableAutoCancel to fix Android auto focus #2169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03c8d3c
Remove DisableAutoCancel to fix android auto focus
Jake-Derrick Aug 27, 2024
abb9759
Merge branch 'main' into bug/cameraview-android-autofocus
Jake-Derrick Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/CommunityToolkit.Maui.Camera/CameraManager.android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using System.Buffers;
using System.Runtime.Versioning;
using System.Runtime.Versioning;
using Android.Content;
using AndroidX.Camera.Core;
using AndroidX.Camera.Core.Impl.Utils.Futures;
Expand Down Expand Up @@ -220,9 +219,7 @@ protected virtual async partial Task PlatformStartCameraPreview(CancellationToke

//start the camera with AutoFocus
MeteringPoint point = previewView.MeteringPointFactory.CreatePoint(previewView.Width / 2.0f, previewView.Height / 2.0f, 0.1f);
FocusMeteringAction action = new FocusMeteringAction.Builder(point)
.DisableAutoCancel()
.Build();
FocusMeteringAction action = new FocusMeteringAction.Builder(point).Build();
camera.CameraControl.StartFocusAndMetering(action);

IsInitialized = true;
Expand Down