Skip to content

update gloas data availability#10357

Closed
mehdi-aouadi wants to merge 13 commits intoConsensys:masterfrom
mehdi-aouadi:10311-gloas-da
Closed

update gloas data availability#10357
mehdi-aouadi wants to merge 13 commits intoConsensys:masterfrom
mehdi-aouadi:10311-gloas-da

Conversation

@mehdi-aouadi
Copy link
Copy Markdown
Contributor

@mehdi-aouadi mehdi-aouadi commented Feb 11, 2026

PR Description

First iteration of updating the Gloas data availability checks logic (moving the kzg commitments from the data column sidecars to the bids). Added some TODOs to avoid having all the changes at once.

Fixed Issue(s)

#10311

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Medium Risk
Touches core data-availability and reconstruction flows and changes the DataColumnSidecar interface, which can impact multiple call sites and fork-specific behavior (especially around Gloas bid-based commitment retrieval).

Overview
Shifts DataColumnSidecar to fork-aware handling of KZG commitments by making getMaybeKzgCommitments() the primary API (and removing the unconditional getKzgCommitments() from the interface), with Fulu providing commitments and Gloas returning none.

Adds DataColumnSidecarUtil.getKzgCommitments(...) (and fork-specific implementations) so consumers can obtain commitments from either the sidecar (Fulu) or the corresponding block’s execution payload bid (Gloas). This is wired into blob/data-column recovery and reconstruction paths (DataColumnSidecarELManagerImpl, BlobSidecarReconstructionProvider, BlobReconstructor) and updates REST SSE data_column_sidecar event serialization to emit the sidecar via its schema instead of a custom payload.

Also removes commitments from data-column sidecar logging output and updates tests to assert against getMaybeKzgCommitments() / DataColumnSidecarFulu.required(...), with TODOs left for fuller Gloas recovery/test coverage.

Written by Cursor Bugbot for commit 79ad77e. This will update automatically on new commits. Configure here.

@mehdi-aouadi mehdi-aouadi self-assigned this Feb 11, 2026
@mehdi-aouadi mehdi-aouadi requested a review from zilm13 February 18, 2026 18:04
@mehdi-aouadi
Copy link
Copy Markdown
Contributor Author

mehdi-aouadi commented Feb 18, 2026

@zilm13 regarding the usage of the kzg proofs instead of the kzg commitments for Gloas, I will take care of that in the next PR since this one doesn't really enable Gloas but rather only sets the ground. Anyway, I'll rebase the next PR on top of this one and we could simply merge the next one and close this one if that works better

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@zilm13
Copy link
Copy Markdown
Contributor

zilm13 commented Feb 24, 2026

I understand that you are trying to cut it in the middle and split between several prs but it's very confusing. I think you should finish here at least simple one lines things

@mehdi-aouadi
Copy link
Copy Markdown
Contributor Author

Closing this one since everything is addressed in #10377

@mehdi-aouadi mehdi-aouadi deleted the 10311-gloas-da branch February 24, 2026 15:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants