update gloas data availability#10357
Closed
mehdi-aouadi wants to merge 13 commits intoConsensys:masterfrom
Closed
Conversation
storage/src/main/java/tech/pegasys/teku/storage/client/BlobSidecarReconstructionProvider.java
Show resolved
Hide resolved
.../java/tech/pegasys/teku/statetransition/datacolumns/util/DataColumnSidecarELManagerImpl.java
Show resolved
Hide resolved
...m/spec/src/main/java/tech/pegasys/teku/spec/logic/versions/fulu/helpers/MiscHelpersFulu.java
Show resolved
Hide resolved
.../java/tech/pegasys/teku/statetransition/datacolumns/util/DataColumnSidecarELManagerImpl.java
Outdated
Show resolved
Hide resolved
2 tasks
zilm13
reviewed
Feb 17, 2026
...c/main/java/tech/pegasys/teku/spec/logic/versions/gloas/util/DataColumnSidecarUtilGloas.java
Outdated
Show resolved
Hide resolved
...c/main/java/tech/pegasys/teku/spec/logic/versions/gloas/util/DataColumnSidecarUtilGloas.java
Outdated
Show resolved
Hide resolved
.../java/tech/pegasys/teku/statetransition/datacolumns/util/DataColumnSidecarELManagerImpl.java
Outdated
Show resolved
Hide resolved
.../java/tech/pegasys/teku/statetransition/datacolumns/util/DataColumnSidecarELManagerImpl.java
Show resolved
Hide resolved
.../java/tech/pegasys/teku/statetransition/datacolumns/util/DataColumnSidecarELManagerImpl.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@zilm13 regarding the usage of the kzg proofs instead of the kzg commitments for Gloas, I will take care of that in the next PR since this one doesn't really enable Gloas but rather only sets the ground. Anyway, I'll rebase the next PR on top of this one and we could simply merge the next one and close this one if that works better |
.../java/tech/pegasys/teku/statetransition/datacolumns/util/DataColumnSidecarELManagerImpl.java
Outdated
Show resolved
Hide resolved
zilm13
reviewed
Feb 23, 2026
storage/src/main/java/tech/pegasys/teku/storage/client/BlobReconstructor.java
Show resolved
Hide resolved
storage/src/main/java/tech/pegasys/teku/storage/client/BlobSidecarReconstructionProvider.java
Show resolved
Hide resolved
storage/src/main/java/tech/pegasys/teku/storage/client/BlobSidecarReconstructionProvider.java
Show resolved
Hide resolved
.../java/tech/pegasys/teku/statetransition/datacolumns/util/DataColumnSidecarELManagerImpl.java
Show resolved
Hide resolved
Contributor
|
I understand that you are trying to cut it in the middle and split between several prs but it's very confusing. I think you should finish here at least simple one lines things |
Contributor
Author
|
Closing this one since everything is addressed in #10377 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
First iteration of updating the Gloas data availability checks logic (moving the kzg commitments from the data column sidecars to the bids). Added some TODOs to avoid having all the changes at once.
Fixed Issue(s)
#10311
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Touches core data-availability and reconstruction flows and changes the
DataColumnSidecarinterface, which can impact multiple call sites and fork-specific behavior (especially around Gloas bid-based commitment retrieval).Overview
Shifts
DataColumnSidecarto fork-aware handling of KZG commitments by makinggetMaybeKzgCommitments()the primary API (and removing the unconditionalgetKzgCommitments()from the interface), with Fulu providing commitments and Gloas returning none.Adds
DataColumnSidecarUtil.getKzgCommitments(...)(and fork-specific implementations) so consumers can obtain commitments from either the sidecar (Fulu) or the corresponding block’s execution payload bid (Gloas). This is wired into blob/data-column recovery and reconstruction paths (DataColumnSidecarELManagerImpl,BlobSidecarReconstructionProvider,BlobReconstructor) and updates REST SSEdata_column_sidecarevent serialization to emit the sidecar via its schema instead of a custom payload.Also removes commitments from data-column sidecar logging output and updates tests to assert against
getMaybeKzgCommitments()/DataColumnSidecarFulu.required(...), with TODOs left for fuller Gloas recovery/test coverage.Written by Cursor Bugbot for commit 79ad77e. This will update automatically on new commits. Configure here.