Skip to content

10311 gloas da#10377

Merged
mehdi-aouadi merged 40 commits intoConsensys:masterfrom
mehdi-aouadi:10311-gloas-da-3
Feb 25, 2026
Merged

10311 gloas da#10377
mehdi-aouadi merged 40 commits intoConsensys:masterfrom
mehdi-aouadi:10311-gloas-da-3

Conversation

@mehdi-aouadi
Copy link
Copy Markdown
Contributor

@mehdi-aouadi mehdi-aouadi commented Feb 13, 2026

PR Description

Update the BlobReconstructor and its implementations to handle Gloas

Fixed Issue(s)

#10311

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Medium Risk
Touches core data-availability recovery, gossip equivocation tracking, and blob reconstruction paths; fork-conditional optional fields and new task-start gating could change when recovery triggers or how many sidecars/blobs are built.

Overview
Adds Gloas support to data-column-sidecar handling by making kzg_commitments, signed headers, and inclusion proofs optional at the DataColumnSidecar interface level and pushing fork-specific behavior into DataColumnSidecarUtil (new APIs to extract commitments, build sidecars, fetch inclusion proofs, and reconstruct all sidecars).

Refactors EL-side recovery (DataColumnSidecarELManagerImpl) and equivocation tracking to be fork-agnostic: recovery can be triggered by either sidecars or blocks, uses a per-task commitments SafeFuture and AtomicBoolean guard, and constructs/publishes recovered sidecars via spec.getDataColumnSidecarUtil(slot) (including new Spec.getNumberOfCustodyGroups(slot) access).

Updates blob reconstruction to work for forks without commitments on sidecars by deriving blob count from proof/column sizes, adding empty-input guards, and using DataColumnSidecarUtil.reconstructAllDataColumnSidecars; adds new Gloas-focused tests and adjusts existing Fulu tests/logging to use getMaybeKzgCommitments() and simplified DataColumnSidecar log output.

Written by Cursor Bugbot for commit e0749dd. This will update automatically on new commits. Configure here.

@mehdi-aouadi mehdi-aouadi self-assigned this Feb 13, 2026
@mehdi-aouadi mehdi-aouadi changed the base branch from master to release-access February 19, 2026 15:00
@mehdi-aouadi mehdi-aouadi changed the base branch from release-access to master February 19, 2026 15:00
@mehdi-aouadi mehdi-aouadi requested a review from zilm13 February 24, 2026 16:05
@mehdi-aouadi mehdi-aouadi changed the title 10311 gloas da 3 10311 gloas da Feb 24, 2026
Copy link
Copy Markdown
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just few nits

@mehdi-aouadi mehdi-aouadi enabled auto-merge (squash) February 25, 2026 10:40
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@mehdi-aouadi mehdi-aouadi enabled auto-merge (squash) February 25, 2026 11:54
@mehdi-aouadi mehdi-aouadi merged commit 706f468 into Consensys:master Feb 25, 2026
109 of 110 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2026
@mehdi-aouadi mehdi-aouadi deleted the 10311-gloas-da-3 branch February 25, 2026 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants