Make setting preferences more convenient#40
Merged
jmark merged 4 commits intoDLR-AMR:mainfrom Nov 14, 2023
Merged
Conversation
This was referenced Nov 4, 2023
ranocha
reviewed
Nov 5, 2023
ranocha
reviewed
Nov 6, 2023
Collaborator
ranocha
left a comment
ranocha
left a comment
There was a problem hiding this comment.
I like this approach. Could you please add a link to the README.md/the repo in the warning?
jmark
suggested changes
Nov 6, 2023
Contributor
jmark
left a comment
jmark
left a comment
There was a problem hiding this comment.
@JoshuaLampert Thanks for your PR! Nice work and a great addition! I just have one comment. Would please consider it?
Collaborator
Author
Done in 0a28f20. |
jmark
approved these changes
Nov 14, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR setting the preferences for T8code.jl becomes more convenient and adapts the setting in P4est.jl
See also my corresponding PR (trixi-framework/P4est.jl#93) in P4est.jl and also trixi-framework/P4est.jl#88 and trixi-framework/P4est.jl#90.
For T8code.jl I propose another function
set_libraries_path!that can be used to set all three preferences conveniently with only one function call by specifying the directory where the libraries are located.Ideally, the preferences for P4est.jl are set from within T8code.jl whenever the preferences for T8code.jl are set to guarantee consistency. However, this is not possible at the moment since T8code.jl does not depend on P4est.jl and thus we cannot set preferences for P4est.jl from T8code.jl.