Set P4est preferences before MPIPreferences#90
Merged
ranocha merged 3 commits intotrixi-framework:mainfrom Oct 17, 2023
Merged
Conversation
Member
Author
|
I enabled the debug mode for p4est since I observed this error also locally. This cannot be caused by this PR and looks like a bug in p4est? I try to reproduce this from C. |
ranocha
reviewed
Oct 16, 2023
Member
ranocha
left a comment
ranocha
left a comment
There was a problem hiding this comment.
Thanks for noticing this! Can we maybe split this PR into two parts?
- The documentation fix can be merged immediately.
- The debug mode stuff can be investigated later.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #88 being merged, it might be necessary to first set the preferences and then the MPIPreferences if you want to use the new convenience functions because otherwise P4est.jl cannot be loaded if the MPIPreferences (with local OpenMPI) are set, but not the P4est preferences. This should not be necessary anymore once P4est_jll is correctly build for OpenMPI. For now I just adjust the instructions in the README.
Additionally, the new functions are used to configure the packages for CI.