Use debug-mode in CI testing#98
Merged
ranocha merged 2 commits intotrixi-framework:mainfrom Nov 22, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage 16.25% 16.25%
=======================================
Files 3 3
Lines 1538 1538
=======================================
Hits 250 250
Misses 1288 1288
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ranocha
reviewed
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed (e.g. here) that
p4estthrows some errors in our tests, when debug-mode is enabled. I therefore suggest to enable--enable-debugin our CI testing as proposed in this PR. I have also adjusted our tests such thatp4estdoesn't throw the errors anymore. This is also related to trixi-framework/Trixi.jl#1358 since therep4estalso throws an error if debug-mode is enabled, although I'm not sure why.