Conversation
* Create deploy.yml Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update .circleci/deploy.yml Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
… off WalletConnect for substrate account
…ng or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Vercel Web Analytics Installation and Configuration
IMPLEMENTATION SUMMARY:
Installed and configured Vercel Web Analytics for Next.js projects in this repository.
FILES CREATED:
None
FILES MODIFIED:
1. examples/with-nextjs/package.json
- Added "@vercel/analytics": "^1.3.1" to dependencies
2. examples/with-nextjs/pages/_app.js
- Added import: import { Analytics } from '@vercel/analytics/next'
- Added <Analytics /> component inside Web3OnboardProvider after {children}
3. examples/with-nextjs-13/package.json
- Added "@vercel/analytics": "^1.3.1" to dependencies
4. examples/with-nextjs-13/pages/_app.tsx
- Added import: import { Analytics } from '@vercel/analytics/next'
- Added <Analytics /> component after <Component {...pageProps} /> wrapped in Fragment
IMPLEMENTATION DETAILS:
Project Structure Analysis:
- This is a monorepo containing multiple packages
- Two Next.js example projects identified: examples/with-nextjs and examples/with-nextjs-13
- Both projects use the Pages Router pattern (pages/_app.js and pages/_app.tsx)
- Projects use yarn as the package manager (based on yarn.lock files)
Changes Made:
1. examples/with-nextjs (Pages Router with JavaScript):
- Updated package.json to include @vercel/analytics dependency
- Added import statement for Analytics component from '@vercel/analytics/next'
- Integrated <Analytics /> component in the MyApp functional component
- Placed Analytics component inside the existing Web3OnboardProvider wrapper and after <Component {...pageProps} />
2. examples/with-nextjs-13 (Pages Router with TypeScript):
- Updated package.json to include @vercel/analytics dependency
- Added import statement for Analytics component from '@vercel/analytics/next'
- Integrated <Analytics /> component in the App functional component
- Wrapped the return statement in a Fragment (<></>) and placed Analytics after <Component {...pageProps} />
DESIGN DECISIONS:
1. Package Version: Used ^1.3.1 for @vercel/analytics to ensure compatibility with modern Next.js versions while allowing minor updates
2. Component Placement:
- For with-nextjs: Placed Analytics inside Web3OnboardProvider to ensure it's within the app's context provider hierarchy
- For with-nextjs-13: Used Fragment wrapper to maintain structural integrity while allowing multiple top-level elements
3. Import Pattern: Used named import pattern consistent with the project's existing import style
VERIFICATION:
- JSON syntax validated for both modified package.json files
- JavaScript/TypeScript syntax verified for both modified _app files
- All imports are properly formatted and follow Next.js conventions
- Component placement follows best practices for Pages Router pattern
NOTES:
- No lockfile updates were performed as this is a monorepo with individual project dependencies
- The @vercel/analytics package is lightweight and will be installed when each project's dependencies are installed
- Analytics component will collect Web Vitals and other analytics data automatically once dependencies are installed
Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com>
Vercel Web Analytics Installation and Configuration
IMPLEMENTATION SUMMARY:
Installed and configured Vercel Web Analytics for Next.js projects in this repository.
FILES CREATED:
None
FILES MODIFIED:
1. examples/with-nextjs/package.json
- Added "@vercel/analytics": "^1.3.1" to dependencies
2. examples/with-nextjs/pages/_app.js
- Added import: import { Analytics } from '@vercel/analytics/next'
- Added <Analytics /> component inside Web3OnboardProvider after {children}
3. examples/with-nextjs-13/package.json
- Added "@vercel/analytics": "^1.3.1" to dependencies
4. examples/with-nextjs-13/pages/_app.tsx
- Added import: import { Analytics } from '@vercel/analytics/next'
- Added <Analytics /> component after <Component {...pageProps} /> wrapped in Fragment
IMPLEMENTATION DETAILS:
Project Structure Analysis:
- This is a monorepo containing multiple packages
- Two Next.js example projects identified: examples/with-nextjs and examples/with-nextjs-13
- Both projects use the Pages Router pattern (pages/_app.js and pages/_app.tsx)
- Projects use yarn as the package manager (based on yarn.lock files)
Changes Made:
1. examples/with-nextjs (Pages Router with JavaScript):
- Updated package.json to include @vercel/analytics dependency
- Added import statement for Analytics component from '@vercel/analytics/next'
- Integrated <Analytics /> component in the MyApp functional component
- Placed Analytics component inside the existing Web3OnboardProvider wrapper and after <Component {...pageProps} />
2. examples/with-nextjs-13 (Pages Router with TypeScript):
- Updated package.json to include @vercel/analytics dependency
- Added import statement for Analytics component from '@vercel/analytics/next'
- Integrated <Analytics /> component in the App functional component
- Wrapped the return statement in a Fragment (<></>) and placed Analytics after <Component {...pageProps} />
DESIGN DECISIONS:
1. Package Version: Used ^1.3.1 for @vercel/analytics to ensure compatibility with modern Next.js versions while allowing minor updates
2. Component Placement:
- For with-nextjs: Placed Analytics inside Web3OnboardProvider to ensure it's within the app's context provider hierarchy
- For with-nextjs-13: Used Fragment wrapper to maintain structural integrity while allowing multiple top-level elements
3. Import Pattern: Used named import pattern consistent with the project's existing import style
VERIFICATION:
- JSON syntax validated for both modified package.json files
- JavaScript/TypeScript syntax verified for both modified _app files
- All imports are properly formatted and follow Next.js conventions
- Component placement follows best practices for Pages Router pattern
NOTES:
- No lockfile updates were performed as this is a monorepo with individual project dependencies
- The @vercel/analytics package is lightweight and will be installed when each project's dependencies are installed
- Analytics component will collect Web Vitals and other analytics data automatically once dependencies are installed
Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @Dargon789, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces Vercel Analytics to the Next.js example applications, enhancing their ability to track usage. More significantly, it performs a major cleanup and update of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on a significant dependency overhaul and refactoring within the demo and injected packages, alongside adding Vercel analytics to the Next.js examples. The changes suggest a migration from a @subwallet-connect fork to the primary @web3-onboard packages and a cleanup of Substrate-related wallet support. While these updates appear intentional, the absence of a descriptive pull request body makes it challenging to fully verify the intended scope. My review has uncovered a critical issue in packages/injected/src/wallets.ts where a required property has been removed from numerous wallet definitions, which will likely cause compilation to fail. I have also identified several medium-severity issues concerning code style and package metadata consistency that should be addressed.
| "url": "https://github.com/blocknative/web3-onboard/issues" | ||
| }, | ||
| "homepage": "https://onboard.blocknative.com", | ||
| "bugs": "https://github.com/blocknative/web3-onboard/issues", |
There was a problem hiding this comment.
The bugs field has been changed from an object to a string. While technically valid, the object format { "url": "..." } is more explicit, extensible, and consistent with other fields in this file, such as repository. I recommend reverting to the object format for better structure and consistency.
| "bugs": "https://github.com/blocknative/web3-onboard/issues", | |
| "bugs": { | |
| "url": "https://github.com/blocknative/web3-onboard/issues" | |
| }, |
| coin98wallet:'Coin98 Wallet', | ||
| SubWallet:'SubWallet' |
There was a problem hiding this comment.
There is a missing space after the colon for the coin98wallet and SubWallet properties. This affects code readability and is inconsistent with the formatting of other properties in this object. Please add a space for consistency.
| coin98wallet:'Coin98 Wallet', | |
| SubWallet:'SubWallet' | |
| coin98wallet: 'Coin98 Wallet', | |
| SubWallet: 'SubWallet' |
| ronin: { | ||
| provider: InjectedProvider | ||
| } |
There was a problem hiding this comment.
A trailing comma is missing for the ronin property in the CustomWindow interface. Trailing commas have been added to other properties in this change, so for consistency, one should be added here as well. This practice improves maintainability by minimizing diff noise when new properties are added.
| ronin: { | |
| provider: InjectedProvider | |
| } | |
| ronin: { | |
| provider: InjectedProvider | |
| }, |
3 participants
Description
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/Tests with demo app (injected)
Tests with demo app (SDK)