Skip to content

Revert "Main"#59

Merged
Dargon789 merged 1 commit intosw-devfrom
revert-58-main
Jan 4, 2026
Merged

Revert "Main"#59
Dargon789 merged 1 commit intosw-devfrom
revert-58-main

Conversation

@Dargon789
Copy link
Copy Markdown
Owner

Reverts #58

This reverts commit 1980044.
@vercel
Copy link
Copy Markdown

vercel bot commented Jan 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
web3-onboard-demo Ready Ready Preview, Comment Jan 4, 2026 9:24am

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Dargon789, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, despite being titled "Revert 'Main'", represents a substantial strategic shift and technical overhaul. It primarily focuses on rebranding the project from Web3-Onboard to SubWallet-Connect and significantly expanding its capabilities by integrating robust support for Substrate-based blockchain wallets alongside the existing EVM wallet infrastructure. This change involves extensive updates to package configurations, dependency management, and the introduction of new wallet modules and identification mechanisms.

Highlights

  • Major Rebranding and Refactoring: The project undergoes a significant transition from 'Web3-Onboard' to 'SubWallet-Connect', impacting package names, dependencies, and core functionalities across multiple modules. This is a substantial change despite the PR title 'Revert Main'.
  • Introduction of Substrate Wallet Support: New wallet modules for Substrate-based ecosystems (e.g., SubWallet Substrate, Talisman Substrate, Polkadot Js) have been integrated, expanding the platform's compatibility beyond EVM.
  • Dependency Updates and Clean-up: The @vercel/analytics dependency has been removed from Next.js examples, and a comprehensive update of various dependencies, including a switch from @web3-onboard/common to @subwallet-connect/common, has been performed.
  • Enhanced Wallet Identification and Metadata: New wallet identities, labels, and external URLs have been added for various wallets, including Bitget and Kayros, improving wallet detection and user guidance within the injected wallets module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a significant number of changes, primarily rolling back modifications related to a subwallet-connect fork and removing Vercel Analytics from example applications. The review focuses on the resulting code state after the revert. While the revert seems to correctly undo previous work, I've identified several issues in the newly introduced code for Substrate wallet support, including a critical bug, opportunities for refactoring to reduce duplication, and improvements in error handling.

@Dargon789 Dargon789 merged commit b380a83 into sw-dev Jan 4, 2026
10 checks passed
@Dargon789 Dargon789 deleted the revert-58-main branch January 4, 2026 09:30
@Dargon789 Dargon789 self-assigned this Jan 4, 2026
@Dargon789 Dargon789 added the good first issue Good for newcomers label Jan 4, 2026
@github-project-automation github-project-automation bot moved this to Done in Hardhat Jan 4, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in web3-Defi-Gamefi Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

Archived in project
Status: Done

1 participant