Issue #1209 bypass value error well assign #1211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoerivanEngelen
changed the base branch from
master
to
imod5_converter_feature_branch
Manangka
requested changes
Sep 13, 2024
| self.name = name | ||
| self.directory = None | ||
| self._initialize_template() | ||
| self._is_from_imod5 = False |
Collaborator
There was a problem hiding this comment.
Hmm imod5 converter logic is now being mixed up with the main logic. I'm not sure this is a good thing
Contributor
Author
There was a problem hiding this comment.
Good point, will be picked up further in #1222
…_ValueError_well_assign
Closed
Manangka
approved these changes
Sep 17, 2024
|
JoerivanEngelen
deleted the
issue_#1209_bypass_ValueError_well_assign
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1209
Description
to_mf6_pkg:error_on_well_removal, which throws an error if wells are removed entirely during well assignment._is_from_imod5to Modflow6Simulation to keep track if the simulation is loaded from iMOD5 data or not. Based on this, some validation settings might be set to be a bit more permissive. (Or call some extra cleanup?)is_from_imod5property to WriteContext to keep track of the same thing within the writing context.Checklist
Issue #nr, e.g.Issue #737