nix store trust: accept Determinate Nix 3.15 and newer, which uses a …

[grahamc]

…bool instead of int

Description

Checklist

• Tested changes against a test repository
• Added or updated relevant documentation (leave unchecked if not applicable)
• (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

Summary by CodeRabbit

• Bug Fixes
  • Extended Nix store trust configuration to accept boolean (true/false) and numeric (1/0) values for enhanced compatibility across different configuration formats.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[netlify]

✅ Deploy Preview for detsys-ts-docs ready!

Name	Link
🔨 Latest commit	c9197bf
🔍 Latest deploy log	https://app.netlify.com/projects/detsys-ts-docs/deploys/695dde69b7324a00083df1a6
😎 Deploy Preview	https://deploy-preview-127--detsys-ts-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

📝 Walkthrough

Walkthrough

The preflightNixStoreInfo function in src/index.ts was modified to broaden the interpretation of the parsed.trusted field. It now accepts boolean values (true/false) in addition to numeric values (1/0) when determining nixStoreTrust status.

Changes

Cohort / File(s)	Summary
Nix Store Trust Validation src/index.ts	Modified conditional checks in preflightNixStoreInfo to accept parsed.trusted === true or parsed.trusted === 1 for "trusted" state, and parsed.trusted === false or parsed.trusted === 0 for "untrusted" state.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hopping through logic so neat,
Booleans and numbers now meet,
True or one, zero or false,
All paths through the store enthrall,
Trust flows truer, complete! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: accepting boolean values in addition to integers for nix store trust to support Determinate Nix 3.15 and newer.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f335f0d and c9197bf.

⛔ Files ignored due to path filters (2)

• dist/index.mjs is excluded by !**/dist/**
• dist/index.mjs.map is excluded by !**/dist/**, !**/*.map

📒 Files selected for processing (1)

• src/index.ts

🧰 Additional context used

🧬 Code graph analysis (1)

src/index.ts (1)

dist/index.mjs (1)

• parsed (1312-1312)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Run all checks

🔇 Additional comments (1)

src/index.ts (1)

1099-1101: LGTM! Clean backward-compatible implementation.

The dual-format support for parsed.trusted (boolean and numeric) is well-implemented and maintains backward compatibility with older Nix versions while supporting Determinate Nix 3.15+. The use of strict equality ensures type safety, and the existing fallback at line 1103 handles any unexpected values appropriately.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}