Update detsys-ts: nix store trust: accept Determinate Nix 3.15 and newer, which uses a bool instead of int (#127)#92
Conversation
… and newer, which uses a bool instead of int (#127)` (`4b33fd06d268e376dd34c17d6ec0d4ebf01d02a9`)
📝 WalkthroughWalkthroughThis change bumps the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom Pre-merge Checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
29-29: Consider pinning detsys-ts to a specific commit for reproducibility.The
detsys-tsdependency uses an unpinned GitHub URL reference. While the lockfile will resolve this to a specific commit, explicitly pinning it in package.json improves clarity and ensures intentional updates.🔎 Proposed fix to pin detsys-ts to specific commit
- "detsys-ts": "github:DeterminateSystems/detsys-ts" + "detsys-ts": "github:DeterminateSystems/detsys-ts#4b33fd06d268e376dd34c17d6ec0d4ebf01d02a9"This makes the dependency version explicit and aligns with the PR objectives.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
dist/index.jsis excluded by!**/dist/**pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and check the TypeScript Action
🔇 Additional comments (2)
package.json (2)
33-33: LGTM: Routine patch update.The
@types/nodebump from^20.19.26to^20.19.27is a routine patch-level update with no breaking changes expected.
1-45: Lockfile correctly updated with expected detsys-ts commit.The pnpm-lock.yaml file contains the correct
detsys-tsresolution:github.com/DeterminateSystems/detsys-ts/4b33fd06d268e376dd34c17d6ec0d4ebf01d02a9. The unpinned GitHub URL in package.json is the correct approach for pnpm; dependency resolution to the specific commit happens via the lockfile, which has been properly updated. The PR successfully implements the intended detsys-ts update for Nix store trust changes (bool vs int in Determinate Nix 3.15+).Likely an incorrect or invalid review comment.
…m DeterminateSystems/dependabot/npm_and_yarn/npm_and_yarn-de653eece3` (`19c948d15e766687225515331fbebc216a14ed06`)
…-update-19c948d15e766687225515331fbebc216a14ed06 Update `detsys-ts`: Merge pull request DeterminateSystems#92 from DeterminateSystems/dependabot/npm_and_yarn/npm_and_yarn-de653eece3
Bump
detsys-tsto the latestHEADand regenerate application bundle.4b33fd06d268e376dd34c17d6ec0d4ebf01d02a9DeterminateSystems/detsys-ts#127f335f0d0939f2b8488174d3cd5f818d1cec23ab6..4b33fd06d268e376dd34c17d6ec0d4ebf01d02a9127.diffSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.