ref: changes draggable card element to be <a> instead of <li>#274
Merged
viniciusoyama merged 1 commit intomainfrom Sep 4, 2025
Merged
ref: changes draggable card element to be <a> instead of <li>#274viniciusoyama merged 1 commit intomainfrom
viniciusoyama merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the card Drag/Drop on Vivaldi browser as reported on #273
Cause
The old HTML structure with a draggable
licontaining anainside was causing the bug (probably because the link was capturing the mouse down event). As explained in the issue, this error doesn't happen with the new implementation using React in the PRO Edition so it's not worth spending too much time checking it.Solution
I've changed the card list structure to be
a div > a.cardinstead oful > li.card > aso theais the draggable elementOBS
The same error happens if we try to drag/drop a column. But in this case we still can execute the action by start the drag on the top-left corner of the column.