Skip to content

ref: changes draggable card element to be <a> instead of <li> #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viniciusoyama merged 1 commit into from
Sep 4, 2025
Merged

ref: changes draggable card element to be <a> instead of <li> #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions app/views/visualizations/_card.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
<li class="cpy-card tour--card issue--card show-issue-finish-toggle-on-hover"
<a class="cpy-card tour--card issue--card show-issue-finish-toggle-on-hover"
id="<%= dom_id(issue) %>"
href="<%= show_visualization_issue_path(visualization, issue) %>"
data-controller="visualization--board--card"
data-favorite-issue-labels-issue-id="<%= issue.id %>"
data-visualization--board--card-scroll-on-connect-value="<%= local_assigns[:scroll_on_connect] == true %>"
data-grouping-column-target="card"
data-grouping-column-issue-id-value="<%= issue.id %>"
data-visualization--issue-filtering-target="issue">
<%= link_to show_visualization_issue_path(visualization, issue),
class: "group relative flex flex-col gap-2 text-sm text-content-500 border-2 border-background-200 bg-background-50 hover:bg-background-100 hover:border-background-900 cursor-pointer shadow-sm rounded-xl card p-3",
data: {
turbo_frame: 'issue_detail',
turbo_action: 'advance'
} do %>
data-visualization--issue-filtering-target="issue"
data-turbo-frame="issue_detail"
data-turbo-action="advance"
>
<div class="group relative flex flex-col gap-2 text-sm text-content-500 border-2 border-background-200 bg-background-50 hover:bg-background-100 hover:border-background-900 cursor-pointer shadow-sm rounded-xl card p-3">

<div class="hidden flex items-center justify-center p-2 text-xs flex group-hover:flex items-center absolute top-2 right-2 rounded-full bg-background-50">
<i class="fa fa-pencil"></i>
Expand All @@ -32,5 +31,5 @@
<%= render partial: 'visualizations/groupings/_card/icons', locals: { issue: } %>

<%= due_date_for(issue) %>
<% end %>
</li>
</div>
</a>
4 changes: 2 additions & 2 deletions app/views/visualizations/_column.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
</div>
</header>

<ul
<div
id="<%= grouping.id %>-cards-wrapper"
class="board--column--card-list js-no-column-drag cpy-drop-zone"
data-controller="sortable"
Expand All @@ -114,7 +114,7 @@
} %>
<% end %>
<% end %>
</ul>
</div>

<div class="board--column--footer">
<%= render partial: 'visualizations/_column/inline_card_form', locals: { grouping:, visualization: } %>
Expand Down