Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4146 +/- ##
==========================================
- Coverage 78.38% 78.38% -0.01%
==========================================
Files 796 796
Lines 103621 103710 +89
==========================================
+ Hits 81226 81288 +62
- Misses 22395 22422 +27
🚀 New features to boost your workflow:
|
rchowell
reviewed
Apr 4, 2025
rchowell
approved these changes
Apr 7, 2025
2eaa60d to
6056e76
Compare
…ersalmind303/dt-to_string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
to_string/strftime.Note for reviewers.
on the python side I added both
to_stringandstrftime, but on sql I only addedstrftime.The reasoning is that because we don't yet have namespaced prefixes on sql, so
to_stringis pretty generic, but on python it'sdt.to_stringwhich fits with ourstr.to_dateandstr.to_datetime.Related Issues
closes #4094
Checklist
docs/mkdocs.ymlnavigation