Skip to content

precommit

0080ae6
Select commit
Loading
Failed to load commit list.
Merged

feat: add strftime #4146

precommit
0080ae6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 9, 2025 in 1s

78.38% (-0.01%) compared to 60a3710

View this Pull Request on Codecov

78.38% (-0.01%) compared to 60a3710

Details

Codecov Report

Attention: Patch coverage is 69.66292% with 27 lines in your changes missing coverage. Please review.

Project coverage is 78.38%. Comparing base (60a3710) to head (0080ae6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-functions/src/temporal/mod.rs 69.23% 12 Missing ⚠️
src/daft-sql/src/modules/temporal.rs 62.96% 10 Missing ⚠️
src/daft-core/src/series/ops/time.rs 63.63% 4 Missing ⚠️
src/daft-functions/src/python/temporal.rs 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4146      +/-   ##
==========================================
- Coverage   78.38%   78.38%   -0.01%     
==========================================
  Files         796      796              
  Lines      103621   103710      +89     
==========================================
+ Hits        81226    81288      +62     
- Misses      22395    22422      +27     
Files with missing lines Coverage Δ
daft/expressions/expressions.py 93.89% <100.00%> (+0.01%) ⬆️
daft/series.py 89.46% <100.00%> (+0.02%) ⬆️
src/daft-core/src/array/ops/time.rs 87.44% <ø> (ø)
src/daft-core/src/python/series.rs 93.57% <100.00%> (+0.02%) ⬆️
src/daft-functions/src/python/mod.rs 100.00% <100.00%> (ø)
src/daft-functions/src/python/temporal.rs 91.66% <75.00%> (-8.34%) ⬇️
src/daft-core/src/series/ops/time.rs 66.34% <63.63%> (-0.16%) ⬇️
src/daft-sql/src/modules/temporal.rs 81.90% <62.96%> (-6.56%) ⬇️
src/daft-functions/src/temporal/mod.rs 66.47% <69.23%> (+0.78%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.