Skip to content

fix: rename notification channels (#196)#533

Merged
naveensingh merged 2 commits intoFossifyOrg:mainfrom
Aga-C:rename_notification_channel_names
Aug 23, 2025
Merged

fix: rename notification channels (#196)#533
naveensingh merged 2 commits intoFossifyOrg:mainfrom
Aga-C:rename_notification_channel_names

Conversation

@Aga-C
Copy link
Copy Markdown
Contributor

@Aga-C Aga-C commented Aug 23, 2025

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Renamed notification channels to not use hardcoded names.
  • As both channels can be used for 5 different things, I've set a very generic names. Let me know if you'd prefer different names.

Before & after preview

ignoreImageMinify ignoreImageMinify

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • All checks are passing.

@Aga-C Aga-C requested a review from naveensingh as a code owner August 23, 2025 07:17
@Aga-C Aga-C changed the title Renamed notification channel names (#196) fix: rename notification channels (#196) Aug 23, 2025
Copy link
Copy Markdown
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on weekends? HR will be pissed.

Thanks.

@naveensingh naveensingh enabled auto-merge (squash) August 23, 2025 07:26
@naveensingh naveensingh merged commit d9713a3 into FossifyOrg:main Aug 23, 2025
6 checks passed
@Aga-C Aga-C deleted the rename_notification_channel_names branch August 23, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notification channel has no name

2 participants