Skip to content

fix: rename notification channels (#196) #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 2 commits into from
Aug 23, 2025
Merged

fix: rename notification channels (#196) #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89dfab5
Renamed notification channel names (#196)
Aga-C Aug 23, 2025
025d6c9
Update CHANGELOG.md
Aga-C Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
### Fixed
- Fixed missing phone number in call history details ([#526])
- Renamed notification channels ([#196])

## [1.6.1] - 2025-07-31
### Changed
Expand Down Expand Up @@ -155,6 +156,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#181]: https://github.com/FossifyOrg/Phone/issues/181
[#183]: https://github.com/FossifyOrg/Phone/issues/183
[#186]: https://github.com/FossifyOrg/Phone/issues/186
[#196]: https://github.com/FossifyOrg/Phone/issues/196
[#237]: https://github.com/FossifyOrg/Phone/issues/237
[#293]: https://github.com/FossifyOrg/Phone/issues/293
[#307]: https://github.com/FossifyOrg/Phone/issues/307
Expand Down
6 changes: 5 additions & 1 deletion app/src/main/kotlin/org/fossify/phone/helpers/CallNotificationManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ class CallNotificationManager(private val context: Context) {
val channelId = if (isHighPriority) "simple_dialer_call_high_priority" else "simple_dialer_call"
if (isOreoPlus()) {
val importance = if (isHighPriority) NotificationManager.IMPORTANCE_HIGH else NotificationManager.IMPORTANCE_DEFAULT
val name = if (isHighPriority) "call_notification_channel_high_priority" else "call_notification_channel"
val name = if (isHighPriority) {
context.getString(R.string.call_notification_channel_high_priority)
} else {
context.getString(R.string.call_notification_channel)
}

NotificationChannel(channelId, name, importance).apply {
setSound(null, null)
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@
<string name="choose_audio_route">Choose audio route</string>
<string name="calling_blocked_number">The number you are calling is blocked</string>
<string name="call_is_being_connected">Your call is being connected…</string>
<string name="call_notification_channel">Call status</string>
<string name="call_notification_channel_high_priority">Call status (high priority)</string>

<!-- Speed dial -->
<string name="speed_dial">Speed dial</string>
Expand Down
Loading