Skip to content

fix: always use proper sorting in favorites fragment#608

Merged
naveensingh merged 8 commits intoFossifyOrg:mainfrom
AATHINARAYANAN-T:389
Oct 16, 2025
Merged

fix: always use proper sorting in favorites fragment#608
naveensingh merged 8 commits intoFossifyOrg:mainfrom
AATHINARAYANAN-T:389

Conversation

@AATHINARAYANAN-T
Copy link
Copy Markdown
Contributor

New custom sorting in favorites tab is not kept until the app is restarted

New custom sorting in favorites tab is not kept until the app is restarted
Copy link
Copy Markdown
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the "Unreleased" section in the changelog as requested by the PR template. You can check other PRs to see how it's done. Example entry: Fixed custom favorites sorting not taking effect until restart.

Also, read the contribution guidelines if you haven't done so.

Comment thread app/src/main/kotlin/org/fossify/phone/fragments/FavoritesFragment.kt Outdated
Comment thread app/src/main/kotlin/org/fossify/phone/fragments/FavoritesFragment.kt Outdated
@naveensingh naveensingh added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Oct 15, 2025
@AATHINARAYANAN-T
Copy link
Copy Markdown
Contributor Author

Please update the "Unreleased" section in the changelog as requested by the PR template. You can check other PRs to see how it's done. Example entry: Fixed custom favorites sorting not taking effect until restart.

Also, read the contribution guidelines if you haven't done so.

ChangeLog Added

Comment thread app/src/main/kotlin/org/fossify/phone/fragments/FavoritesFragment.kt Outdated
Comment thread CHANGELOG.md Outdated
Co-authored-by: Naveen Singh <36371707+naveensingh@users.noreply.github.com>
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
@naveensingh naveensingh linked an issue Oct 16, 2025 that may be closed by this pull request
7 tasks
@naveensingh naveensingh changed the title Update FavoritesFragment.kt fix: always use proper sorting in favorites fragment Oct 16, 2025
Comment thread app/src/main/kotlin/org/fossify/phone/fragments/FavoritesFragment.kt Outdated
Copy link
Copy Markdown
Member

@naveensingh naveensingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it myself, thanks!

Notes for the future:

  • Do not remove PR template.
  • Link the issue you are working on as required in the template. It won't get automatically closed otherwise.

@naveensingh naveensingh merged commit e2c636e into FossifyOrg:main Oct 16, 2025
5 checks passed
@naveensingh naveensingh removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New custom sorting in favorites tab is not kept until the app is restarted

2 participants