fix(macos): show file picker by adding user-selected read-only entitlement #3111

CharlVS · 2025-08-27T11:57:16Z

This PR fixes the macOS seed import file picker not showing (#3054).

Changes

Add com.apple.security.files.user-selected.read-only to macos/Runner/DebugProfile.entitlements and macos/Runner/Release.entitlements to enable system file picker access.
Bump iOS deployment target to 13.0 in ios/Runner.xcodeproj/project.pbxproj and ios/Flutter/AppFrameworkInfo.plist.
Update file_picker to ^10.3.2 and refresh lockfiles.

References

…ement - Add com.apple.security.files.user-selected.read-only to DebugProfile and Release entitlements to enable file_picker dialog on macOS.\n- Bump iOS deployment target to 13.0 (project settings and AppFrameworkInfo.plist) to align with plugin requirements.\n- Update file_picker to ^10.3.2 and refresh lockfiles (iOS/macOS).\n\nRefs: https://github.com/miguelpruivo/flutter_file_picker/wiki/Setup

coderabbitai · 2025-08-27T11:57:22Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/macos-file-picker

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

DeckerSU

The web build using flutter build web --no-pub -v failed with:

alance * overallReturn[mode]!) / ohlcvData.first.close;
                                                                             ^
           lib/bloc/cex_market_data/mockup/generate_demo_data.dart:100:61:
           Error: The getter 'closeTime' isn't defined for the type 'Ohlc'.
            - 'Ohlc' is from 'package:komodo_cex_market_data/src/models/coin_ohlc.dart' ('../../../.pub-cache/hosted/pub.dev/komodo_cex_market_data-0.0.3+1/lib/src/models/coin_ohlc.dart').
                     fromTradeAmount(coinId, tradeAmount, isBuy, ohlcv.closeTime);
                                                                       ^^^^^^^^^
           lib/bloc/cex_market_data/mockup/generate_demo_data.dart:108:17:
           Error: The getter 'closeTime' isn't defined for the type 'Ohlc'.
            - 'Ohlc' is from 'package:komodo_cex_market_data/src/models/coin_ohlc.dart' ('../../../.pub-cache/hosted/pub.dev/komodo_cex_market_data-0.0.3+1/lib/src/models/coin_ohlc.dart').
                     ohlcv.closeTime + 100,
                           ^^^^^^^^^
           lib/bloc/cex_market_data/mockup/generate_demo_data.dart:158:24:
           Error: 'CexCoinPair' isn't a type.
               final ohlcvData = <CexCoinPair, List<Ohlc>>{};
                                  ^^^^^^^^^^^
           lib/bloc/cex_market_data/mockup/generate_demo_data.dart:160:16:
           Error: 'CexCoinPair' isn't a type.
               for (final CexCoinPair coin in coinPairs) {
                          ^^^^^^^^^^^
           lib/bloc/cex_market_data/mockup/generate_demo_data.dart:172:38:
           Error: Too few positional arguments: 3 required, 2 given.
                     await _ohlcRepo.getCoinOhlc(coin, interval, startAt: startAt);
                                                ^
           lib/bloc/cex_market_data/mockup/generate_demo_data.dart:177:25:
           Error: Too few positional arguments: 3 required, 2 given.
                       .getCoinOhlc(coin, GraphInterval.oneHour, startAt: twoWeeksAgo)
                                   ^
           lib/bloc/cex_market_data/profit_loss/profit_loss_calculator.dart:69:45:
           Error: The argument type 'String' can't be assigned to the parameter type 'AssetId'.
            - 'AssetId' is from 'package:komodo_defi_types/src/assets/asset_id.dart' ('../../../.pub-cache/hosted/pub.dev/komodo_defi_types-0.3.2+1/lib/src/assets/asset_id.dart').
               return _cexRepository.getCoinFiatPrices(cleanCoinId, dates);
                                                       ^
           lib/bloc/cex_market_data/profit_loss/profit_loss_calculator.dart:69:27:
           Error: A value of type 'Future<Map<DateTime, Decimal>>' can't be returned from an async function with return type 'Future<Map<DateTime, double>>'.
            - 'Future' is from 'dart:async'.
            - 'Map' is from 'dart:core'.
            - 'DateTime' is from 'dart:core'.
            - 'Decimal' is from 'package:decimal/decimal.dart' ('../../../.pub-cache/hosted/pub.dev/decimal-3.2.1/lib/decimal.dart').
               return _cexRepository.getCoinFiatPrices(cleanCoinId, dates);
                                     ^
           lib/bloc/fiat/fiat_onramp_form/fiat_form_state.dart:31:44:
           Error: 'FiatCurrency' is imported from both 'package:komodo_cex_market_data/src/models/quote_currency.dart' and 'package:web_dex/bloc/fiat/models/i_currency.dart'.
                 : selectedFiat = CurrencyInput.dirty(FiatCurrency.usd()),
                                                      ^^^^^^^^^^^^
           lib/views/wallet/coin_details/coin_details_info/charts/coin_sparkline.dart:17:41:
           Error: The argument type 'String' can't be assigned to the parameter type 'AssetId'.
            - 'AssetId' is from 'package:komodo_defi_types/src/assets/asset_id.dart' ('../../../.pub-cache/hosted/pub.dev/komodo_defi_types-0.3.2+1/lib/src/assets/asset_id.dart').
                 future: repository.fetchSparkline(abbr2Ticker(coinId)),
                                                   ^
           Error: Compilation failed.
             Command: /Users/builder/development/flutter/bin/cache/dart-sdk/bin/dart compile js --platform-binaries=/Users/builder/development/flutter/bin/cache/flutter_web_sdk/kernel --invoker=flutter_tool -Ddart.vm.product=true -DFLUTTER_VERSION=3.35.2 -DFLUTTER_CHANNEL=stable -DFLUTTER_GIT_URL=https://github.com/flutter/flutter.git -DFLUTTER_FRAMEWORK_REVISION=05db968908 -DFLUTTER_ENGINE_REVISION=a8bfdfc394 -DFLUTTER_DART_VERSION=3.9.0 -DFLUTTER_WEB_USE_SKIA=true -DFLUTTER_WEB_USE_SKWASM=false -DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/a8bfdfc394deaed5c57bd45a64ac4294dc976a72/ --native-null-assertions --no-source-maps -O4 --minify -o /Users/builder/jenkins/workspace/komodo-wallet-macos/.dart_tool/flutter_build/1c1f1ce47170f43fa468d87a74f171be/app.dill --packages=/Users/builder/jenkins/workspace/komodo-wallet-macos/.dart_tool/package_config.json --cfe-only /Users/builder/jenkins/workspace/komodo-wallet-macos/.dart_tool/flutter_build/1c1f1ce47170f43fa468d87a74f171be/main.dart
           #0      RunResult.throwException (package:flutter_tools/src/base/process.dart:118:5)
           #1      _DefaultProcessUtils.run (package:flutter_tools/src/base/process.dart:344:19)
           <asynchronous suspension>
           #2      Dart2JSTarget.build (package:flutter_tools/src/build_system/targets/web.dart:204:5)
           <asynchronous suspension>
           #3      _BuildInstance._invokeInternal (package:flutter_tools/src/build_system/build_system.dart:873:9)
           <asynchronous suspension>
           #4      Future.wait.<anonymous closure> (dart:async/future.dart:525:21)
           <asynchronous suspension>
           #5      _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart:811:32)
           <asynchronous suspension>
           #6      Future.wait.<anonymous closure> (dart:async/future.dart:525:21)
           <asynchronous suspension>
           #7      _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart:811:32)
           <asynchronous suspension>
           #8      FlutterBuildSystem.build (package:flutter_tools/src/build_system/build_system.dart:631:16)
           <asynchronous suspension>
           #9      WebBuilder.buildWeb (package:flutter_tools/src/web/compile.dart:90:34)
           <asynchronous suspension>
           #10     BuildWebCommand.runCommand (package:flutter_tools/src/commands/build_web.dart:282:5)
           <asynchronous suspension>
           #11     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1581:27)
           <asynchronous suspension>
           #12     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19)
           <asynchronous suspension>
           #13     CommandRunner.runCommand (package:args/command_runner.dart:212:13)
           <asynchronous suspension>
           #14     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:503:9)
           <asynchronous suspension>
           #15     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19)
           <asynchronous suspension>
           #16     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:438:5)
           <asynchronous suspension>
           #17     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:98:11)
           <asynchronous suspension>
           #18     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19)
           <asynchronous suspension>
           #19     main (package:flutter_tools/executable.dart:101:3)
           <asynchronous suspension>

[   +2 ms] Compiling lib/main.dart for the Web... (completed in 10.3s)
[        ] "flutter web" took 10,640ms.
[   +4 ms] executing: sw_vers -productName
[  +13 ms] Exit code 0 from: sw_vers -productName
[        ] macOS
[        ] executing: sw_vers -productVersion
[  +13 ms] Exit code 0 from: sw_vers -productVersion
[        ] 15.5
[        ] executing: sw_vers -buildVersion
[  +11 ms] Exit code 0 from: sw_vers -buildVersion
[        ] 24F74
[        ] executing: uname -m
[   +5 ms] Exit code 0 from: uname -m
[        ] x86_64
[  +12 ms] Error: Failed to compile application for the Web.
[        ] 
           #0      throwToolExit (package:flutter_tools/src/base/common.dart:34:3)
           #1      WebBuilder.buildWeb (package:flutter_tools/src/web/compile.dart:132:7)
           <asynchronous suspension>
           #2      BuildWebCommand.runCommand (package:flutter_tools/src/commands/build_web.dart:282:5)
           <asynchronous suspension>
           #3      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1581:27)
           <asynchronous suspension>
           #4      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19)
           <asynchronous suspension>
           #5      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
           <asynchronous suspension>
           #6      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:503:9)
           <asynchronous suspension>
           #7      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19)
           <asynchronous suspension>
           #8      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:438:5)
           <asynchronous suspension>
           #9      run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:98:11)
           <asynchronous suspension>
           #10     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19)
           <asynchronous suspension>
           #11     main (package:flutter_tools/executable.dart:101:3)
           <asynchronous suspension>


[        ] Running 1 shutdown hook
[   +1 ms] Shutdown hooks complete
[  +24 ms] exiting with code 1

I guess it is a komodo_defi_framework version incompatibility.

DeckerSU · 2025-08-27T15:50:31Z

It seems the build error is related to #3113 / #3110 (review). But in any case, it can’t be reviewed until the build errors are resolved.

…into fix/macos-file-picker # Conflicts: # ios/Podfile.lock # macos/Podfile.lock

github-actions · 2025-08-31T19:36:39Z

Visit the preview URL for this PR (updated for commit 46a55e6):

https://walletrc--pull-3111-merge-x7mlzln6.web.app

_{(expires Mon, 08 Sep 2025 11:07:22 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc}

DeckerSU · 2025-09-01T07:37:06Z

The seed import phrase (file open) dialog appeared, so the problem described in the initial issue seems resolved. However, I found another similar bug with the "Download seed phrase file" (file save) dialog - it doesn’t appear. I’ve attached a video. I think the best approach would be to fix this within the same PR.

Monosnap.screencast.2025-09-01.09-29-51.mp4

DeckerSU · 2025-09-01T07:45:21Z

Currently the app only includes the entitlement:

<key>com.apple.security.files.user-selected.read-only</key>
<true/>

This works for the file open dialog, but it prevents the save dialog (NSSavePanel) from appearing. According to Apple’s sandboxing rules, the save dialog requires the read-write entitlement:

<key>com.apple.security.files.user-selected.read-write</key>
<true/>

We should update both DebugProfile.entitlements and Release.entitlements to use the read-write entitlement instead of read-only, so that file saving works properly on macOS.

…te entitlement - Replace com.apple.security.files.user-selected.read-only with read-write in DebugProfile and Release entitlements to allow NSSavePanel. Refs: https://developer.apple.com/documentation/bundleresources/entitlements/com_apple_security_files_user-selected_read-write, #3111 (comment)

DeckerSU

LGTM now. I can confirm that the Export and Import seed dialogs work as expected on macOS. Thanks for the prompt fix.

CharlVS linked an issue Aug 27, 2025 that may be closed by this pull request

Import Wallet “Upload seed phrase file” button does not open file dialog on macOS #3054

Closed

CharlVS self-assigned this Aug 27, 2025

CharlVS requested review from DeckerSU and smk762 August 27, 2025 11:59

CharlVS added the QA Ready for QA Testing label Aug 27, 2025

CharlVS added this to the v0.9.3 Release milestone Aug 27, 2025

CharlVS removed the QA Ready for QA Testing label Aug 27, 2025

CharlVS marked this pull request as draft August 27, 2025 12:07

DeckerSU requested changes Aug 27, 2025

View reviewed changes

CharlVS marked this pull request as ready for review August 31, 2025 19:25

CharlVS added 2 commits August 31, 2025 21:31

Merge branch 'dev' of https://github.com/KomodoPlatform/komodo-wallet …

72932a0

…into fix/macos-file-picker # Conflicts: # ios/Podfile.lock # macos/Podfile.lock

chore: roll native ios/macos deps

d3d47ca

CharlVS requested a review from DeckerSU August 31, 2025 19:34

CharlVS added 2 commits September 1, 2025 13:02

Merge branch 'dev' into fix/macos-file-picker

0358571

DeckerSU approved these changes Sep 1, 2025

View reviewed changes

CharlVS merged commit 8ede0e2 into dev Sep 2, 2025
12 of 16 checks passed

CharlVS deleted the fix/macos-file-picker branch September 2, 2025 10:13

CharlVS mentioned this pull request Oct 5, 2025

chore(release): v0.9.3 #3164

Merged

CharlVS mentioned this pull request Nov 3, 2025

chore(release): Re-land v0.9.3 release #3349

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(macos): show file picker by adding user-selected read-only entitlement #3111

fix(macos): show file picker by adding user-selected read-only entitlement #3111

Uh oh!

CharlVS commented Aug 27, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Aug 27, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

DeckerSU left a comment

Uh oh!

DeckerSU commented Aug 27, 2025

Uh oh!

github-actions bot commented Aug 31, 2025 •

edited

Loading

Uh oh!

DeckerSU commented Sep 1, 2025

Uh oh!

DeckerSU commented Sep 1, 2025

Uh oh!

DeckerSU left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(macos): show file picker by adding user-selected read-only entitlement #3111

fix(macos): show file picker by adding user-selected read-only entitlement #3111

Uh oh!

Conversation

CharlVS commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

DeckerSU left a comment

Choose a reason for hiding this comment

Uh oh!

DeckerSU commented Aug 27, 2025

Uh oh!

github-actions bot commented Aug 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DeckerSU commented Sep 1, 2025

Uh oh!

DeckerSU commented Sep 1, 2025

Uh oh!

DeckerSU left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CharlVS commented Aug 27, 2025 •

edited

Loading

coderabbitai bot commented Aug 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Aug 31, 2025 •

edited

Loading