fix(auth): prevent allowlist bypass via sender_id token splitting#1677
Merged
fix(auth): prevent allowlist bypass via sender_id token splitting#1677
Conversation
This was referenced Mar 8, 2026
Mazahir26
added a commit
to Mazahir26/nanobot
that referenced
this pull request
Mar 8, 2026
Upstream changes integrated: - PR HKUDS#1635: Agent config/workspace CLI support - PR HKUDS#1677: Fix auth allowlist bypass via sender_id token splitting - PR HKUDS#1467: DingTalk group chat support - PR HKUDS#436: Preserve Telegram document extension - PR HKUDS#1482: Telegram topic support - PR HKUDS#1535: Fix Telegram proxy crash - PR HKUDS#332: Feishu event handlers - Azure OpenAI provider support - Multi-instance path cleanup and workspace override preservation - Slack empty text response handling - QQ group @message support Conflicts resolved: - .gitignore: Preserved user's tests/ and QWEN.md entries - nanobot/agent/tools/mcp.py: Merged upstream's SSE transport support with user's dict compatibility for backward compatibility Tests: 169 passed Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
linziyanleo
added a commit
to linziyanleo/nanobot__ava
that referenced
this pull request
Mar 12, 2026
合并上游 165 commits（52 文件，+3288/-377 行），解决 6 个冲突文件： - agent/loop.py: 保留 fork 的多模型/工具扩展，接纳上游变量名规范 - channels/telegram.py: 合并 fork 的 proxy 优化 + 上游的 streaming/table/stop/topic - cli/commands.py: 合并 fork 的 console server + 上游的 Windows/Azure/multi-instance - config/schema.py: 合并双方 Config 扩展（fork 压缩/心跳 + 上游 Discord/Azure） - providers/registry.py: 保留 fork 的 zenmux/yunwu + 引入上游 Azure provider - skills/memory/SKILL.md: 保留 fork 三维度记忆架构 上游关键合入： - 安全修复 HKUDS#1677 allowlist bypass - 稳定性修复 HKUDS#1728 MCP CancelledError - MCP SSE 传输 HKUDS#1488 - Azure OpenAI provider HKUDS#1618 - 工具参数自动类型转换 HKUDS#1610 - read_file 大小限制 HKUDS#1511 适配测试以匹配 fork 自定义行为（206 tests passed）。
robottwo
pushed a commit
to robottwo/nanobot
that referenced
this pull request
Mar 13, 2026
…d token splitting fix(auth): prevent allowlist bypass via sender_id token splitting
sorker
pushed a commit
to sorker/nanobot
that referenced
this pull request
Mar 24, 2026
…d token splitting fix(auth): prevent allowlist bypass via sender_id token splitting
Wattysaid
pushed a commit
to kieran-assistant/nanobot
that referenced
this pull request
Apr 3, 2026
…d token splitting fix(auth): prevent allowlist bypass via sender_id token splitting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseChannel.is_allowed()caused by global|token splitting onsender_idid|usernamematching insideTelegramChannel.is_allowed()Why
BaseChannel.is_allowed()previously treatedsender_idas a tokenized string and allowed any|-separated segment to satisfyallow_from. This made the authorization boundary too permissive for channels that pass externally controlled sender identifiers.This change removes that global behavior from the base class and scopes Telegram's legacy compatibility logic to the Telegram channel only, where the historical
id|usernameformat originated.Backward Compatibility
id|usernameentriesallow_frommatches|token splitting outside Telegram, but that behavior is now treated as unsafe and is intentionally removedSecurity Impact
This change closes an authorization bypass where attacker-controlled composite
sender_idvalues could match allowlisted tokens through global|splitting.