fix(feishu): Prevent error logs from unhandled reaction and read events#332
Merged
Re-bin merged 3 commits intoHKUDS:mainfrom Mar 7, 2026
Merged
fix(feishu): Prevent error logs from unhandled reaction and read events#332Re-bin merged 3 commits intoHKUDS:mainfrom
Re-bin merged 3 commits intoHKUDS:mainfrom
Conversation
… chat events - Register handlers for message reaction created events - Register handlers for message read events - Register handlers for bot entering p2p chat events - Prevent error logs for these common but unprocessed events - Import required event types from lark_oapi
Re-bin
added a commit
that referenced
this pull request
Mar 7, 2026
Mazahir26
added a commit
to Mazahir26/nanobot
that referenced
this pull request
Mar 8, 2026
Upstream changes integrated: - PR HKUDS#1635: Agent config/workspace CLI support - PR HKUDS#1677: Fix auth allowlist bypass via sender_id token splitting - PR HKUDS#1467: DingTalk group chat support - PR HKUDS#436: Preserve Telegram document extension - PR HKUDS#1482: Telegram topic support - PR HKUDS#1535: Fix Telegram proxy crash - PR HKUDS#332: Feishu event handlers - Azure OpenAI provider support - Multi-instance path cleanup and workspace override preservation - Slack empty text response handling - QQ group @message support Conflicts resolved: - .gitignore: Preserved user's tests/ and QWEN.md entries - nanobot/agent/tools/mcp.py: Merged upstream's SSE transport support with user's dict compatibility for backward compatibility Tests: 169 passed Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
robottwo
pushed a commit
to robottwo/nanobot
that referenced
this pull request
Mar 13, 2026
sorker
pushed a commit
to sorker/nanobot
that referenced
this pull request
Mar 24, 2026
Wattysaid
pushed a commit
to kieran-assistant/nanobot
that referenced
this pull request
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds event handlers for common Feishu/Lark events that were previously unhandled, preventing error logs from cluttering the application output.
Changes
P2ImMessageReactionCreatedV1)P2ImMessageMessageReadV1)P2ImChatAccessEventBotP2pChatEnteredV1)lark_oapi.api.im.v1Motivation
When users interact with the Feishu bot (e.g., reacting to messages, reading messages, or opening chat windows), these events trigger callbacks but were not registered, causing error logs. While these events don't require processing for the bot's core functionality, registering empty handlers prevents unnecessary error messages and improves log cleanliness.
Technical Details
Testing
Related Issues
Fixes issues with error logs appearing when users: