Skip to content

move detoken to serving_client#1741

Merged
xuechendi merged 1 commit intohabana_mainfrom
dev/habana_main_openai_detoken_move_to_server
Aug 13, 2025
Merged

move detoken to serving_client#1741
xuechendi merged 1 commit intohabana_mainfrom
dev/habana_main_openai_detoken_move_to_server

Conversation

@xuechendi
Copy link
Copy Markdown

@xuechendi xuechendi commented Aug 11, 2025 •
edited by github-actions Bot
Loading

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results

Purpose

please refer to #1735 for explaination

Test Plan

Test Result

@xuechendi
move detoken to serving_client
081e881 
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
@xuechendi xuechendi force-pushed the dev/habana_main_openai_detoken_move_to_server branch from 207f240 to 081e881 Compare August 11, 2025 20:49
@xuechendi
Copy link
Copy Markdown
Author

xuechendi commented Aug 11, 2025

/run-gaudi-tests

@xuechendi xuechendi changed the title [SW-234412] port 1735 to habana_main - move detoken to serving_client move detoken to serving_client Aug 13, 2025
@xuechendi xuechendi merged commit 50b55ad into habana_main Aug 13, 2025
48 checks passed
@xuechendi xuechendi deleted the dev/habana_main_openai_detoken_move_to_server branch August 13, 2025 16:04
@shepark shepark mentioned this pull request Aug 18, 2025
Merged
michalkuligowski pushed a commit that referenced this pull request Aug 29, 2025
@shepark
Add detok in chat completion fn for non stream mode when VLLM_DETOKEN…
06a6d5d 
…IZE_ON_OPENAI_SERVER=true (#1768)

Adding missing part in #1741
for chat_completion_full_generator().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mswiniarsk mswiniarsk mswiniarsk approved these changes

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@madamczyk-intel madamczyk-intel Awaiting requested review from madamczyk-intel madamczyk-intel is a code owner

@michalkuligowski michalkuligowski Awaiting requested review from michalkuligowski michalkuligowski is a code owner

@mgawarkiewicz-intel mgawarkiewicz-intel Awaiting requested review from mgawarkiewicz-intel mgawarkiewicz-intel is a code owner

@vivekgoe vivekgoe Awaiting requested review from vivekgoe

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

@jikunshang jikunshang Awaiting requested review from jikunshang jikunshang is a code owner

@PatrykWo PatrykWo Awaiting requested review from PatrykWo PatrykWo is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xuechendi @mswiniarsk