Add detok in chat completion fn for non stream mode when VLLM_DETOKENIZE_ON_OPENAI_SERVER=true#1768
Merged
michalkuligowski merged 3 commits intohabana_mainfrom Aug 29, 2025
Merged
Conversation
When VLLM_DETOKENIZE_ON_OPENAI_SERVER=true
shepark
requested review from
PatrykWo,
afierka-intel,
jikunshang,
kzawora-intel,
madamczyk-intel,
mgawarkiewicz-intel,
michalkuligowski,
mswiniarsk,
vivekgoe and
xuechendi
as code owners
|
there are two files, serving_chat.py and serving_completion.py, does the other once also need to have same change? |
Author
Actually, it's needed for our customer support only for now. |
|
/run-gaudi-tests |
xuechendi
approved these changes
Aug 25, 2025
xuechendi
left a comment
xuechendi
left a comment
There was a problem hiding this comment.
Needed by customer, ok to have partially supported per author's request
|
/run-gaudi-tests |
michalkuligowski
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding missing part in #1741 for chat_completion_full_generator().