opentelemetry-cpp 1.11.0#140216
Merged
BrewTestBot merged 2 commits intoHomebrew:masterfrom Sep 2, 2023
Merged
Conversation
p-linnane
reviewed
Aug 22, 2023
64c3949 to
f1aa831
Compare
Contributor
|
The test fails with |
This comment was marked as resolved.
This comment was marked as resolved.
f1aa831 to
6565048
Compare
ZhongRuoyu
reviewed
Sep 2, 2023
Member
There was a problem hiding this comment.
This combined with the WITH_STL cmake option above should fix it. Without them, opentelemetry-cpp uses its own STL implementation, which depends on an internal, bundled abseil. That's not compatible with the abseil that protobuf uses.
Member
There was a problem hiding this comment.
Uh, it was a bit too early to say that. Now we've got another problem 😅
Member
There was a problem hiding this comment.
It doesn't work with Big Sur's libc++ for some reason. Let's not use WITH_STL then. In that case we can still fix this by defining HAVE_ABSEIL.
Failure on Big Sur, for reference
In file included from /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/exporters/otlp/src/otlp_http_client.cc:4:
In file included from /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_client.h:8:
In file included from /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/api/include/opentelemetry/nostd/variant.h:9:
/tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/api/include/opentelemetry/std/variant.h:61:8: error: call to implicitly-deleted copy constructor of 'std::variant'
auto v = t;
^ ~
/tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/api/include/opentelemetry/std/variant.h:113:10: note: in instantiation of function template specialization 'opentelemetry::nostd::(anonymous class)::operator() &>' requested here
return get_type(v);
^
/tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/exporters/otlp/src/otlp_http_client.cc:733:31: note: in instantiation of function template specialization 'opentelemetry::nostd::get' requested here
opentelemetry::nostd::get(session);
^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/c++/v1/variant:1204:3: note: explicitly defaulted function was implicitly deleted here
variant(const variant&) = default;
^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/c++/v1/variant:1173:7: note: copy constructor of 'variant' is implicitly deleted because base class '__sfinae_ctor_base<__all, is_copy_constructible_v>::value, __all, is_move_constructible_v>::value>' has a deleted copy constructor
: private __sfinae_ctor_base<
^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/c++/v1/__tuple:515:3: note: '__sfinae_ctor_base' has been explicitly marked deleted here
__sfinae_ctor_base(__sfinae_ctor_base const&) = delete;
^
In file included from /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/exporters/otlp/src/otlp_http_client.cc:4:
In file included from /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_client.h:8:
In file included from /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/api/include/opentelemetry/nostd/variant.h:9:
/tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/api/include/opentelemetry/std/variant.h:61:8: error: call to implicitly-deleted copy constructor of 'std::variant'
auto v = t;
^ ~
/tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/api/include/opentelemetry/std/variant.h:113:10: note: in instantiation of function template specialization 'opentelemetry::nostd::(anonymous class)::operator() &>' requested here
return get_type(v);
^
/tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/exporters/otlp/src/otlp_http_client.cc:741:46: note: in instantiation of function template specialization 'opentelemetry::nostd::get' requested here
addSession(std::move(opentelemetry::nostd::get(session)));
^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/c++/v1/variant:1204:3: note: explicitly defaulted function was implicitly deleted here
variant(const variant&) = default;
^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/c++/v1/variant:1173:7: note: copy constructor of 'variant' is implicitly deleted because base class '__sfinae_ctor_base<__all, is_copy_constructible_v>::value, __all, is_move_constructible_v>::value>' has a deleted copy constructor
: private __sfinae_ctor_base<
^
/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/c++/v1/__tuple:515:3: note: '__sfinae_ctor_base' has been explicitly marked deleted here
__sfinae_ctor_base(__sfinae_ctor_base const&) = delete;
^
- opentelemetry-cpp: unversioned grpc and protobuf - opentelemetry-cpp: depend on abseil; remove noop WITH_LOGS_PREVIEW=ON - opentemetry-cpp: define `HAVE_ABSEIL` in test Co-authored-by: Alexander Bayandin <alexander@bayandin.dev> Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
6565048 to
c137a81
Compare
bayandin
approved these changes
Sep 2, 2023
Contributor
|
🤖 An automated task has requested bottles to be published to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.Details
release notes
and exporter packages:
What's Changed
opentelemetry_proto_grpcagainst [shared] gRPC lib by @ays7 in added public link ofopentelemetry_proto_grpcagainst [shared] gRPC lib open-telemetry/opentelemetry-cpp#2268Notes
New Contributors
Full Changelog: open-telemetry/opentelemetry-cpp@v1.10.0...v1.11.0