Mark logs signal as stable API/SDK#2229
Merged
ThomsonTan merged 24 commits intoopen-telemetry:mainfrom Aug 1, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2229 +/- ##
==========================================
+ Coverage 87.32% 87.62% +0.31%
==========================================
Files 169 198 +29
Lines 4897 5856 +959
==========================================
+ Hits 4276 5131 +855
- Misses 621 725 +104
|
Member
|
Per discussion in C++ SIG meeting (2023-07-12):
before merging this PR. |
ThomsonTan
changed the title
marcalff
reviewed
Jul 27, 2023
Member
marcalff
left a comment
marcalff
left a comment
There was a problem hiding this comment.
Looks good overall.
See a comment on empty_attributes.h
marcalff
approved these changes
Jul 27, 2023
lalitb
reviewed
Aug 1, 2023
| the current OpenTelemetry Log specification matures. The current | ||
| implementation can be included in build by setting `ENABLE_LOGS_PREVIEW` | ||
| preprocessor macro. | ||
| | Logs | Public Release | N/A | |
Member
There was a problem hiding this comment.
Any plans to update the compliance matrix before marking this stable?
Contributor
Author
There was a problem hiding this comment.
Yes, will update it.
lalitb
reviewed
Aug 1, 2023
lalitb
reviewed
Aug 1, 2023
lalitb
reviewed
Aug 1, 2023
| #include "opentelemetry/sdk/logs/logger_provider.h" | ||
| #include "opentelemetry/sdk/logs/read_write_log_record.h" | ||
| #include "opentelemetry/sdk/logs/simple_log_record_processor.h" | ||
| #include "opentelemetry/sdk/version/version.h" |
Member
There was a problem hiding this comment.
Some of the above headers have been added twice, Can you please check this once.
Contributor
Author
There was a problem hiding this comment.
I didn't see any header file is included twice directly. Do you mean some header file in the list is also included indirectly?
Contributor
Author
There was a problem hiding this comment.
I think we can fix this later if it is an issue.
lalitb
reviewed
Aug 1, 2023
lalitb
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2172
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes