Skip to content

Add subcanopy nutrient uptakes into the soil model#1071

Merged
jacobcook1995 merged 2 commits intodevelopfrom
1058-integrate-subcanopy-nutrient-uptakes-into-the-soil-model
Oct 3, 2025
Merged

Add subcanopy nutrient uptakes into the soil model#1071
jacobcook1995 merged 2 commits intodevelopfrom
1058-integrate-subcanopy-nutrient-uptakes-into-the-soil-model

Conversation

@jacobcook1995
Copy link
Copy Markdown
Collaborator

Description

This PR changes the soil model so that supcanopy nutrient uptake actually removes nutrients from the appropriate pools

Fixes #1058

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@jacobcook1995 jacobcook1995 linked an issue Oct 3, 2025 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.60%. Comparing base (4dd1336) to head (88ee1cb).
⚠️ Report is 1126 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1071   +/-   ##
========================================
  Coverage    94.60%   94.60%           
========================================
  Files           79       79           
  Lines         6937     6937           
========================================
  Hits          6563     6563           
  Misses         374      374           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobcook1995 jacobcook1995 merged commit 9ad8b0e into develop Oct 3, 2025
13 checks passed
@jacobcook1995 jacobcook1995 deleted the 1058-integrate-subcanopy-nutrient-uptakes-into-the-soil-model branch October 3, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate subcanopy nutrient uptakes into the soil model

3 participants