Conversation
… into 1118-move-configuration-use-in-main-over-to-new-configuration
…system' into 1118-move-configuration-use-in-main-over-to-new-configuration
…m' into 1118-move-configuration-use-in-main-over-to-new-configuration
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1122 +/- ##
===========================================
- Coverage 94.69% 87.76% -6.93%
===========================================
Files 90 90
Lines 7872 7803 -69
===========================================
- Hits 7454 6848 -606
- Misses 418 955 +537 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…m' into 1118-move-configuration-use-in-main-over-to-new-configuration
…system' into 1118-move-configuration-use-in-main-over-to-new-configuration
… into 1118-move-configuration-use-in-main-over-to-new-configuration
… into 1118-move-configuration-use-in-main-over-to-new-configuration
… into 1118-move-configuration-use-in-main-over-to-new-configuration
…move-configuration-use-in-main-over-to-new-configuration
…move-configuration-use-in-main-over-to-new-configuration
…move-configuration-use-in-main-over-to-new-configuration
…at were raising notes
…m' into 1118-move-configuration-use-in-main-over-to-new-configuration
…system' into 1118-move-configuration-use-in-main-over-to-new-configuration
… into 1118-move-configuration-use-in-main-over-to-new-configuration
…move-configuration-use-in-main-over-to-new-configuration
…m' into 1118-move-configuration-use-in-main-over-to-new-configuration
…to-new-configuration
…to-new-configuration
…ration' of https://github.com/ImperialCollegeLondon/virtual_rainforest into 1118-move-configuration-use-in-main-over-to-new-configuration
Collaborator
Author
|
@sallymatson Finally got docs fixed. Could you have a look? It's very sprawling so please add as many "What the hell is happening here" questions as you need! Or we can chat IRL 😄 |
sallymatson
approved these changes
Nov 3, 2025
…to-new-configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the last remaining uses of the old configuration system and strips out all remaining calls to old
Configobjects in the model code and tests.The PR does not
core/constants.py,core/constants_loader.pyandcore/config.pyand all associated tests. That PR should also migrate any appropriate tests of the old system onto the new system.A lot of files are affected. The broad changes are:
model.from_config- because the new system pre-validates, these checks are redundant and can be removed.from_config(..., config, ...)argument from the BaseModel and then everywhere else. This was needed in parallel during the switch over but Move animals over to the new configuration system #1116, Move hydrology over to the new configuration system #1114, Move both abiotic models over to the new configuration system #1115 and Snagging the config system switch over in science models #1124 have replaced all cases where this input was used.config_mergeincore/config.py- it was looking for schema that no longer exist. The same is true forload_constants- it was looking for the now removed constants classes from the registry. Both function have had the problematic code commented out.CompiledConfigurationclass that gets populated with a list of the models and BaseModel subclasses used in it. This was present in the oldConfigand is used inmainfor getting run order and other things.load_data_configto use the new configuration and also simplified the signatures of functions incore/data.pythat were passing in whole config dicts but only needed a single path out of them.That's about it 😬
Fixes #1118
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks