Skip to content

Snagging the config system switch over in science models#1124

Merged
davidorme merged 9 commits intodevelopfrom
1123-snagging-the-config-system-switch-over
Nov 3, 2025
Merged

Snagging the config system switch over in science models#1124
davidorme merged 9 commits intodevelopfrom
1123-snagging-the-config-system-switch-over

Conversation

@davidorme
Copy link
Copy Markdown
Collaborator

@davidorme davidorme commented Oct 28, 2025

Description

This PR catches a number of things that snuck through some of the other model conversion PRs. Notably there was a lot of usage of old style config stuff in the litter model that I missed. A few in the plants model.

I also added some new constants fixtures using the new system to reduce the amount of importing in tests and to avoid repeatedly creating constants classes in testing.

Fixes #1123

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@davidorme davidorme linked an issue Oct 28, 2025 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.69%. Comparing base (834a8df) to head (8310cf6).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1124   +/-   ##
========================================
  Coverage    94.69%   94.69%           
========================================
  Files           90       90           
  Lines         7872     7872           
========================================
  Hits          7454     7454           
  Misses         418      418           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidorme davidorme marked this pull request as ready for review October 28, 2025 21:33
@davidorme davidorme merged commit 54d5001 into develop Nov 3, 2025
13 checks passed
@davidorme davidorme deleted the 1123-snagging-the-config-system-switch-over branch November 3, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snagging the config system switch over.

3 participants