First draft of nicely styled team page:#690
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #690 +/- ##
========================================
Coverage 93.96% 93.96%
========================================
Files 75 75
Lines 5828 5828
========================================
Hits 5476 5476
Misses 352 352 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think this looks nice! I personally think that having longer descriptions probably removes the need for separating out into groups, but it depends what others think |
|
I think it probably makes sense to break up the grid a little and have: Project leadership: Rob and Liv |
We also need to work out where Anna best fits as well |
|
I couldn't switch branch and when I do I tried |
What does this show? It should list all remote branches And does this do anything: |
does show all the branches, and gave But I still get |
|
Sorry I deleted to last comment because it was misleading. I was trying various thing, but when I tried |
for more information, see https://pre-commit.ci
…CollegeLondon/virtual_ecosystem into 688-update-project-team
for more information, see https://pre-commit.ci
…CollegeLondon/virtual_rainforest into 688-update-project-team
for more information, see https://pre-commit.ci
…CollegeLondon/virtual_rainforest into 688-update-project-team
for more information, see https://pre-commit.ci
|
@sallymatson Does this completed page look ok for now? |
|
@jacobcook1995 This just dropped off the radar. I'm updating to |
jacobcook1995
left a comment
There was a problem hiding this comment.
LGTM! Think it makes sense just to merge it (as people have had time to give feedback), and then if anything still needs to be fixed that can be done in a separate PR
Description
This PR does two things:
We've set the website builder to build the changes on the branch for this pull request and you can see the results of building the new page here: https://virtual-ecosystem.readthedocs.io/en/688-update-project-team/project_team.html
We now need all team members to commit changes to this PR to add their details and fill out the page. You will need to:
Install Git on your computer, if you do not already have it: https://git-scm.com/downloads
Clone the
virtual_ecosystemrepository. This will create a new directory on your computer so you first need to decide where you want to put it. Open a terminal in that root directory and run:You should now have a
virtual_ecosystemfolder. In your terminal, change directory into that terminal and then run:You should now be looking at the specific versions of the files that are being edited on this request.
If you want to include a photo - you don't have to - edit a photo of yourself. We're after small photos (roughly 200 x 300 pixels or that sort of shape and size. Within the
virtual_ecosystemrepo, you need to save it in the folderdocs/source/_static/images/peopleunder your name.Within the
virtual_ecosystemrepo, open the filedocs/source/project_team.md. This is a file written in the Markdown format that our documentation system converts into HTML. You will need to edit your entry (like the one shown below) in three ways:project_team.htmltohttps://your.homepage.url_static/images/people/photo_placeholder.pngto_static/images/people/your_photo_name.jpg:::{grid-item-card} Dr. Taran Rallings :margin: 2 2 0 0 :link: project_team.html ```{image} _static/images/people/photo_placeholder.png :alt: Dr. Taran Rallings :class: team-photo ``` Lorem ipsum odor amet, consectetuer adipiscing elit. Velit dolor tellus ligula ligula montes tellus eget. Accumsan platea blandit porta imperdiet curabitur varius himenaeos egestas. :::Now you need to commit those changes. There are three steps that need to be run from the command line in the
virtual_ecosystemrepo:gitso add it:git add docs/source/_static/images/people/your_photo_name.jpggit add docs/source/project_team.mdLastly - those changes are only on your computer. You now need to run
git pushto send the details to GitHub.Fixes #688 (issue)
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks