Skip to content

Update sphinx to 8.1#729

Merged
davidorme merged 4 commits intodevelopfrom
727-update-sphinx-to-81
Feb 6, 2025
Merged

Update sphinx to 8.1#729
davidorme merged 4 commits intodevelopfrom
727-update-sphinx-to-81

Conversation

@davidorme
Copy link
Copy Markdown
Collaborator

@davidorme davidorme commented Feb 6, 2025

Description

This PR:

  • Updates pyproject.toml to use sphinx ^8.0.0, which is currently 8.1.3. We may need to be careful about the next release as it drop python 3.10 support. I think that is just that we'd have to run sphinx in python 3.11+ but something to keep in mind.

  • Updates conf.py to:

    • Mute Sphinx 9 deprecation warnings
    • Remove some odd jupytext cruft that had crept in
  • Adds the TODO extension to give nice clear TODO sections in docstrings. I've updated hydrology_model.py to use the directive and check it works and is rendering.

  • Fixes a test bug - xarray is also upgraded in this and they have changed the wording on KeyErrors with Dataset objects.

The main reason for doing this was I upgraded to see if it fixed a bug. It didn't but we might as well upgrade it.

Fixes #727

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@davidorme davidorme linked an issue Feb 6, 2025 that may be closed by this pull request
@davidorme davidorme added this to the Documentation system milestone Feb 6, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.70%. Comparing base (39f2f88) to head (d49918b).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #729   +/-   ##
========================================
  Coverage    94.70%   94.70%           
========================================
  Files           73       73           
  Lines         4946     4946           
========================================
  Hits          4684     4684           
  Misses         262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidorme davidorme merged commit 185e4c9 into develop Feb 6, 2025
@davidorme davidorme deleted the 727-update-sphinx-to-81 branch February 6, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update sphinx to 8.1

3 participants