Conversation
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #729 +/- ##
========================================
Coverage 94.70% 94.70%
========================================
Files 73 73
Lines 4946 4946
========================================
Hits 4684 4684
Misses 262 262 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Updates
pyproject.tomlto usesphinx ^8.0.0, which is currently8.1.3. We may need to be careful about the next release as it droppython 3.10support. I think that is just that we'd have to runsphinxinpython 3.11+but something to keep in mind.Updates
conf.pyto:Adds the TODO extension to give nice clear TODO sections in docstrings. I've updated
hydrology_model.pyto use the directive and check it works and is rendering.Fixes a test bug -
xarrayis also upgraded in this and they have changed the wording on KeyErrors withDatasetobjects.The main reason for doing this was I upgraded to see if it fixed a bug. It didn't but we might as well upgrade it.
Fixes #727
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks