Skip to content

Stop negative growth rates from resulting in negative enzyme productions#920

Merged
jacobcook1995 merged 1 commit intodevelopfrom
892-calculate_enzyme_production-function-can-produce-enzymes-at-a-negative-rate
Jun 25, 2025
Merged

Stop negative growth rates from resulting in negative enzyme productions#920
jacobcook1995 merged 1 commit intodevelopfrom
892-calculate_enzyme_production-function-can-produce-enzymes-at-a-negative-rate

Conversation

@jacobcook1995
Copy link
Copy Markdown
Collaborator

Description

This PR changes the calculation of enzyme production so that when microbial growth rates are negative (which can happen if mycorrhiza can't meet nutrient demands) the enzyme production rates don't go negative

Fixes #892

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.96%. Comparing base (21a5636) to head (917b82d).
⚠️ Report is 1857 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #920   +/-   ##
========================================
  Coverage    93.96%   93.96%           
========================================
  Files           77       77           
  Lines         5862     5864    +2     
========================================
+ Hits          5508     5510    +2     
  Misses         354      354           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobcook1995 jacobcook1995 merged commit f47818d into develop Jun 25, 2025
16 checks passed
@jacobcook1995 jacobcook1995 deleted the 892-calculate_enzyme_production-function-can-produce-enzymes-at-a-negative-rate branch June 25, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

calculate_enzyme_production function can produce enzymes at a negative rate

3 participants