Issue #64: Persist Write Sync flag; show Write* in Mode; keep UI lean #77
Conversation
vpstackhub
commented
Aug 27, 2025
vpstackhub
commented
- Add Boolean writeSyncEnabled to Benchmark entity
- Set writeSyncEnabled in BenchmarkWorker (WRITE runs); null for READ
- UI: render Mode as "Write*" when write-sync enabled (no new column)
- Keep table layout unchanged; removed ad-hoc width overrides; added tooltip
- Verified persistence across restarts; no behavior change for READ
- Minor cleanup included
- Minor formatting/indentation adjustments applied where needed
…; minor cleanup - Add Boolean writeSyncEnabled to Benchmark entity - Set writeSyncEnabled in BenchmarkWorker (WRITE runs); null for READ - UI: render Mode as 'Write*' when write-sync enabled (no new column) - Keep table layout unchanged; remove ad-hoc width overrides; add tooltip - Verified persistence across restarts; no behavior change for READ
jamesmarkchan
left a comment
jamesmarkchan
left a comment
There was a problem hiding this comment.
hey val same behavior as before
lines 21 - 46 should be indented more by four spaces each
also lines 140-146 should be indented more by four spaces
generally a tell tale sign is we should see a closing bracket on the first column until the very end of a java file.
also we can move the method getModeDisplay() into the Benchmark.java.
|
looking good, just some minor items. :) |
|
@vpstackhub could we add these two lines to your changes? Should fix the setting of the IOPS fields when a benchmark is selected. 
|
- Move getModeDisplay() to Benchmark and use it from BenchmarkPanel - Persist writeSyncEnabled for WRITE; null for READ - Show 'Write*' in Mode via Benchmark.getModeDisplay - Wire IOPS into Gui.loadBenchmark (App.rIops/App.wIops) - Indentation fixes in BenchmarkPanel; tighten cast spacing
|
Updates applied:
This should address all outstanding review notes. thanks for the guidance! |
src/jdiskmark/Benchmark.java
Outdated
| if (ioMode == IOMode.WRITE && Boolean.TRUE.equals(getWriteSyncEnabled())) { | ||
| return "Write*"; | ||
| } | ||
| return (ioMode == null) ? "" : ioMode.toString(); // "Read", "Write", "Read & Write" |
There was a problem hiding this comment.
Almost perfect val, just lines 169 and 173 should be indented by x4 spaces more each. If you don't mind I'll go ahead and do these for you but in the future nice for you to do them so the author of those lines reflect as yourself. :)
|
@vpstackhub interesting that "resolving a conversation" will collapse it and i guess puts it int the background. I went ahead and merged the branch, traditionally most groups delete the branch after merging to minimize clutter, there was a button that allowed me to delete it on the server but to delete the branch on your system to reduce clutter |
|
Thanks so much for merging this on my behalf and for the feedback throughout ,especially the UI lean suggestion and the clean up touches. I’ll keep an eye on the details like indentation next time. Appreciate your guidance as always! |
Issue #64: Persist Write Sync flag; show Write* in Mode; keep UI lean
