Conversation
johnnychen94
approved these changes
Jan 20, 2020
Member
There was a problem hiding this comment.
Since almost all packages under JuliaImages requires OffsetArray, we shouldn't expect any performance boost in Images.jl side by doing this. But yes, in ImageShow.jl side, it requires less.
P.S. I was doing a Julia installer and release mirror project and thus missed some recent activities. It might take a few more days.
timholy
changed the title
johnnychen94
added a commit
that referenced
this pull request
Mar 16, 2020
this commit reverts #17 because * OffsetArrays has 1.0 release; CompatHelper notification would be less frequently * ImageCore also depends on OffsetArrays; Requires doesn't help in saving the loading time
johnnychen94
added a commit
that referenced
this pull request
Mar 16, 2020
this commit reverts #17 because * OffsetArrays has 1.0 release; CompatHelper notification would be less frequent * ImageCore also depends on OffsetArrays; Requires doesn't help in saving the loading time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
collectcall handles offset axes quite generally, so the specialized method is mostly redundant. It does, however, reduce memory consumption, so I decided to keep it but put it behind a@require. Since we're already using Requires in this package, that doesn't seem like unnecessary overhead.The main advantage of eliminating unnecessary dependencies is less CompatHelper busy work.