Closed
Conversation
This was referenced Mar 13, 2020
Member
Author
|
Since MosaicView depends on OffsetArrays, I think it's ok to revert #17. With OffsetArray 1.0 released, the main motivation of that is "outdated" now. Edit: just realized that |
Collaborator
|
Looks fine so far. Do you have a design for a test? |
Member
Author
ReferenceTests are designed for such usages 😄 -- the 22 reference images occupy 88K storage, which is small enough to manage with git. |
Member
Author
|
The test fails because ColorVectorSpace isn't compatible with ColorTypes v0.10 JuliaGraphics/ColorVectorSpace.jl#128 With a modified Project.toml, it's passed locally. |
Member
Author
|
@timholy do you think it's appropriate to move this PR to ImageCore? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge this until JuliaArrays/MosaicViews.jl#14 get merged, I will rebuild the test when MosaicViews v0.2.0 is registered.TODO:
I bumped a minor version because from now on this package isn't invisible to users anymore. After this, I'll also reexport
ImageShowfromImages, and then draft a democard in juliaimages.orgAnother choice is to reexport it in
ImageCorebecauseImageCoreis a collection of different views.MosaicViewsprovides a handy toolmosaicview, which can be seen as an enhanced version ofcatto make visualization easier. Here're two main usages: