Support atsign-__MODULE__ by timholy · Pull Request #363 · JuliaLang/Compat.jl

timholy · 2017-06-07T10:43:59Z

JuliaLang/julia#22064. CC @vtjnash.

timholy · 2017-06-07T10:44:23Z

Probably also worth CCing @JobJob just to make sure I didn't break his invokelatest stuff.

vtjnash · 2017-06-07T16:36:29Z

src/Compat.jl

+if !isdefined(Base, Symbol("@__MODULE__"))
+    export @__MODULE__
+    macro __MODULE__()
+        esc(:(current_module()))


should be just return current_module() (if it had needed the function call, you also wouldn't have wanted the esc either)

vtjnash · 2017-06-07T16:37:25Z

src/Compat.jl

+        esc(:(current_module()))
+    end
+    Base.binding_module(mod::Module, s::Symbol) = Base.binding_module(s)
+    Base.expand(mod::Module, x::ANY) = expand(x)


all of these functions should take the form eval(mod, :(expand($(QuoteNode(x))))

vtjnash · 2017-06-07T16:38:42Z

src/Compat.jl

    import Base.invokelatest
 else
-    invokelatest(f, args...) = eval(current_module(), Expr(:call, f, map(QuoteNode, args)...))
+    invokelatest(f, args...) = eval(@__MODULE__, Expr(:call, f, map(QuoteNode, args)...))


invokelatest was introduced first, so this change is unnecessary

timholy · 2017-06-07T16:54:20Z

Thanks, @vtjnash!

Also add auxiliary methods deprecated by atsign-__MODULE__ change

JobJob · 2017-06-07T11:06:26Z

test/runtests.jl

 end
-@test Compat.invokelatest(current_module) === current_module()
+cm359() = @__MODULE__
+@test Compat.invokelatest(cm359) === @__MODULE__


Maybe add a === current_module() here?

Will emit a depwarn on 0.7. But perhaps worth it?

Just while testing yeah? Anyway, I doubt it will ever make a difference, and if you, stevengj and vtjnash are happy, I think we're probably pretty ok 😄

musm · 2017-06-19T04:00:35Z

Would it be possible to also add support for https://github.com/JuliaLang/julia/blob/3c3ced4153cdc2c75319b41155c38ad1f2545fc2/base/boot.jl#L233
i.e. include accepting a module in the first argument

vtjnash · 2017-06-19T05:01:22Z

include doesn't take a module as the first argument. Perhaps you meant Base.include, which is not exported anymore, but does?

musm · 2017-06-19T05:04:58Z

Yes sorry I meant Base.include

* Bump required Julia version to 1.0 * Remove compatibility support code for: * `at-__MODULE__` (from #363) * `devnull`, `stdin`, `stdout`, and `stderr` from #499 * `at-nospecialize` (from #385 and #409) * `isabstracttype` and `isconcretetype` (from #477) * `invokelatest` from #424 * array-like access to `Cmd` from #379 * `Val(n)` and `ntuple`/`reshape` with `Val` from #381 and #399 * `logdet(::Any)` fallback from #382 * `chol(::UniformScaling)` from #382 * `pushfirst!`, `popfirst!` from #444 * `fieldcount` from #386 * `read(obj, ::Type{String})` from #385 and #580 * `InexactError`, `DomainError`, and `OverflowError` constructors from #393 * `corrected` kw arg to `cov` from #401 * `adjoint` from #401 * `partialsort` from #401 * `pairs` from #428 * `AbstractRange` from #400 * `rtoldefault` from #401 * `Dates.Period` rounding from #462 * `IterativeEigensolvers` from #435 * `occursin` from #520 * `Char` concatenation from #406 * `BitSet` from #407 * `diagm` and `spdiagm` with pairs from #408 * `Array` c'tors from `UniformScaling` from #412 and #438 * `IOContext` ctor taking pairs from #427 * `undef` from #417 and #514 * `get` on `ENV` from #430 * `ComplexF...` from #431 * `tr` from #614 * `textwidth` from #644 * `isnumeric` from #543 * `AbstractDict` from #435 * `axes` #435 and #442 * `Nothing` and `Cvoid` from #435 * `Compat.SuiteSparse` from #435 * `invpermute!` from #445 * `replace` with a pair from #445 * `copyto!` from #448 * `contains` from #452 * `CartesianIndices` and `LinearIndices` from #446, #455, and #524 * `findall` from #466 (and #467). * `argmin` and `argmax` from #470, #472, and #622 * `parentmodule` from #461 * `codeunits` from #474 * `nameof` from #471 * `GC` from #477 * `AbstractDisplay` from #482 * `bytesavailable` from #483 * `firstindex` and `lastindex` from #480 and #494 * `printstyled` from #481 * `hasmethod` from #486 * `objectid` from #486 * `Compat.find*` from #484 and #513 * `repr` and `showable` from #497 * `Compat.names` from #493 and #505 * `Compat.round` and friends #500, #530, and #537 * `IOBuffer` from #501 and #504 * `range` with kw args and `LinRange` from #511 * `cp` and `mv` from #512 * `indexin` from #515 * `isuppercase` and friends from #516 * `dims` and `init` kwargs from #518, #528, #590, #592, and #613 * `selectdim` from #522 and #531 * `repeat` from #625 * `fetch(::Task)` from #549 * `isletter` from #542 * `isbitstype` from #560 * `at-cfunction` from #553 and #566 * `codeunit` and `thisind` and friends from #573 * `something` from #562 * `permutedims` from #582 * `atan` from #574 * `split` and `rsplit` from #572 * `mapslices` from #588 * `floatmin` and `floatmax` from #607 * `dropdims` from #618 * required keyword arguments from #586 * `CartesianRange` in `at-compat` from #377 * `finalizer` from #416 * `readline`, `eachline`, and `readuntil` from #477, #541, and #575 * curried `isequal`, `==`, and `in` from #517 * `Some` from #435 and #563 * `at-warn` and friends from #458 * Remove old deprecations * Deprecate: * `Compat.Sockets` from #545 and #594 * `TypeUtils` from #304 * `macros_have_sourceloc` from #355 * `Compat.Sys` from #380, #433, and #552 * `Compat.MathConstants` from #401 * `Compat.Test`, `Compat.SharedArrays`, `Compat.Mmap`, and `Compat.DelimitedFiles` from #404 * `Compat.Dates` from #413 * `Compat.Libdl` from #465 (and #467) * `AbstractDateTime` from #443 * `Compat.Printf` from #435 * `Compat.LinearAlgebra` from #463 * `Compat.SparseArrays` from #459 * `Compat.Random` from #460, #601, and #647 * `Compat.Markdown` from #492 * `Compat.REPL` from #469 * `Compat.Serialization` from #473 * `Compat.Statistics` from #583 * `Fix2` from #517 * `Compat.Base64` from #418 * `Compat.Unicode` from #432 and #507 * `notnothing` from #435 and #563 * `Compat.IteratorSize` and `Compat.IteratorEltype` from #451 * `enable_debug(::Bool)` from #458 * `Compat.Distributed` from #477 * `Compat.Pkg` from #485 * `Compat.InteractiveUtils` from #485 * `Compat.LibGit2` from #487 * `Compat.UUIDs` from #490 * `Compat.qr` from #534 * `Compat.rmul!` from #546 * `Compat.norm` abd friends from #577 * Remove obsolete README entry, missed in #385 * Remove obsolete tests (e.g. missed in #372) * Remove obsolete `VERSION` conditionals and some minor clean-up

vtjnash requested changes Jun 7, 2017

View reviewed changes

timholy force-pushed the teh/MODULE branch from cee5b4a to 7639a22 Compare June 7, 2017 16:54

Add atsign-__MODULE__ from Julia 0.7/1.0

8ed726c

Also add auxiliary methods deprecated by atsign-__MODULE__ change

timholy force-pushed the teh/MODULE branch from 7639a22 to 8ed726c Compare June 7, 2017 21:44

stevengj approved these changes Jun 8, 2017

View reviewed changes

JobJob reviewed Jun 8, 2017

View reviewed changes

vtjnash approved these changes Jun 8, 2017

View reviewed changes

timholy merged commit 2436d35 into master Jun 8, 2017

timholy deleted the teh/MODULE branch June 8, 2017 17:24

martinholters added a commit that referenced this pull request Sep 29, 2019

Drop compat code for at-__MODULE__ (from #363)

bec7c71

martinholters added a commit that referenced this pull request Sep 29, 2019

Drop compat code for at-__MODULE__ (from #363)

523a220

martinholters added a commit that referenced this pull request Oct 8, 2019

Drop compat code for at-__MODULE__ (from #363)

20b3ff8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support atsign-MODULE#363

Support atsign-MODULE#363
timholy merged 1 commit intomasterfrom
teh/MODULE

timholy commented Jun 7, 2017

Uh oh!

timholy commented Jun 7, 2017

Uh oh!

vtjnash Jun 7, 2017

Uh oh!

vtjnash Jun 7, 2017

Uh oh!

vtjnash Jun 7, 2017

Uh oh!

timholy commented Jun 7, 2017

Uh oh!

JobJob Jun 7, 2017

Uh oh!

timholy Jun 8, 2017

Uh oh!

JobJob Jun 8, 2017

Uh oh!

musm commented Jun 19, 2017 •

edited

Loading

Uh oh!

vtjnash commented Jun 19, 2017

Uh oh!

musm commented Jun 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

timholy commented Jun 7, 2017

Uh oh!

timholy commented Jun 7, 2017

Uh oh!

vtjnash Jun 7, 2017

Choose a reason for hiding this comment

Uh oh!

vtjnash Jun 7, 2017

Choose a reason for hiding this comment

Uh oh!

vtjnash Jun 7, 2017

Choose a reason for hiding this comment

Uh oh!

timholy commented Jun 7, 2017

Uh oh!

JobJob Jun 7, 2017

Choose a reason for hiding this comment

Uh oh!

timholy Jun 8, 2017

Choose a reason for hiding this comment

Uh oh!

JobJob Jun 8, 2017

Choose a reason for hiding this comment

Uh oh!

musm commented Jun 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vtjnash commented Jun 19, 2017

Uh oh!

musm commented Jun 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

musm commented Jun 19, 2017 •

edited

Loading